Skip to content

Bug 1954177: Update mao dependency for webhook v1 changes#103

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
elmiko:bz1954177-webhook-update
May 10, 2021
Merged

Bug 1954177: Update mao dependency for webhook v1 changes#103
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
elmiko:bz1954177-webhook-update

Conversation

@elmiko
Copy link

@elmiko elmiko commented May 5, 2021

This change updates the machine-api-operator dependency to pickup
changes for the AdmissionReviewVersions for webhooks.

ref: openshift/machine-api-operator#855

@openshift-ci-robot
Copy link

@elmiko: This pull request references Bugzilla bug 1954177, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

Details

In response to this:

Bug 1954177: Update mao dependency for webhook v1 changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels May 5, 2021
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: elmiko
To complete the pull request process, please assign rgolangh after the PR has been reviewed.
You can assign the PR to them by writing /assign @rgolangh in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Gal-Zaidman
Copy link

Hi now that the release PR is merged just rebase and I'll lgtm it

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 9, 2021
This change updates the machine-api-operator dependency to pickup
changes for the AdmissionReviewVersions for webhooks.

ref: openshift/machine-api-operator#855
@elmiko elmiko force-pushed the bz1954177-webhook-update branch from ef674c9 to 8f81281 Compare May 10, 2021 15:29
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 10, 2021
@Gal-Zaidman
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 10, 2021
@openshift-ci
Copy link

openshift-ci bot commented May 10, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elmiko, Gal-Zaidman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 10, 2021
@openshift-merge-robot openshift-merge-robot merged commit 242c41e into openshift:master May 10, 2021
@openshift-ci
Copy link

openshift-ci bot commented May 10, 2021

@elmiko: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 1954177 has not been moved to the MODIFIED state.

Details

In response to this:

Bug 1954177: Update mao dependency for webhook v1 changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants