Skip to content
This repository was archived by the owner on Feb 17, 2022. It is now read-only.

Bug 1954177: Update mao dependency for webhook v1 changes#35

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
elmiko:mao-update-a132ec00
May 15, 2021
Merged

Bug 1954177: Update mao dependency for webhook v1 changes#35
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
elmiko:mao-update-a132ec00

Conversation

@elmiko
Copy link

@elmiko elmiko commented May 4, 2021

No description provided.

@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label May 4, 2021
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 4, 2021

@elmiko: This pull request references Bugzilla bug 1954177, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

Details

In response to this:

Bug 1954177: Update mao dependency for webhook v1 changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label May 4, 2021
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 4, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: elmiko
To complete the pull request process, please assign nirarg after the PR has been reviewed.
You can assign the PR to them by writing /assign @nirarg in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@elmiko
Copy link
Author

elmiko commented May 4, 2021

this is going to need these 2 patches to merge, then be re-vendored to include them:
openshift/cluster-api-provider-azure#216
openshift/cluster-api-provider-aws#407
/hold

This was referenced May 4, 2021
Merged
Merged
@elmiko elmiko force-pushed the mao-update-a132ec00 branch from 71dc51d to a9d2754 Compare May 5, 2021 16:01
@elmiko
Copy link
Author

elmiko commented May 5, 2021

this is failing go vet due to an old go lang version (1.13)

@elmiko elmiko mentioned this pull request May 5, 2021
Merged
6 tasks
@elmiko
Copy link
Author

elmiko commented May 10, 2021

/retest

@elmiko
Bug 1954177: Update mao dependency for webhook v1 changes
163e13c 
Also adds a fix in the nodeupdate_controller.go for a module change in
the vendor update.
@elmiko elmiko force-pushed the mao-update-a132ec00 branch from a9d2754 to 163e13c Compare May 12, 2021 22:04
@elmiko
Copy link
Author

elmiko commented May 12, 2021 •
edited
Loading

updated to include a controller-runtime bump, see openshift/cluster-api-provider-baremetal#151 (comment) for discussion

@nirarg
Copy link

nirarg commented May 13, 2021

/test e2e-kubevirt

@nirarg
Copy link

nirarg commented May 13, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 13, 2021
@openshift-ci
Copy link

openshift-ci bot commented May 13, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elmiko, nirarg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2021
@openshift-bot
Copy link

openshift-bot commented May 13, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link

openshift-bot commented May 13, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented May 14, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented May 14, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented May 14, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented May 14, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented May 14, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented May 14, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link

openshift-bot commented May 14, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented May 15, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented May 15, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit b0e15d7 into openshift:master May 15, 2021
@openshift-ci
Copy link

openshift-ci bot commented May 15, 2021

@elmiko: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 1954177 has not been moved to the MODIFIED state.

Details

In response to this:

Bug 1954177: Update mao dependency for webhook v1 changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@elmiko elmiko deleted the mao-update-a132ec00 branch May 17, 2021 14:14
@openshift-ci openshift-ci bot mentioned this pull request May 18, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sunzhaohua2 sunzhaohua2 Awaiting requested review from sunzhaohua2

@ravidbro ravidbro Awaiting requested review from ravidbro

@rgolangh rgolangh Awaiting requested review from rgolangh

Assignees

@nirarg nirarg

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@elmiko @openshift-ci-robot @nirarg @openshift-bot @openshift-merge-robot

Comments