-
Notifications
You must be signed in to change notification settings - Fork 65
candidate-4.3: allow 4.2 s390x upgrades #229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I don't see an arch spinner on the 4.2.28 product page, but the presence of 4.2.28 in fast-4.2 and stable-4.2 suggests it is supported on all arches. As master stands with: $ git --no-pager log --oneline -1 --format='%h %s'
38d6bcf Merge pull request #237 from openshift/pr-candidate-4.2.33we appear to have different stability claims for 4.2.28 depending on minor version: $ git --no-pager grep 4.2.28
channels/candidate-4.2.yaml:- 4.2.28
channels/candidate-4.3.yaml:- 4.2.28+amd64
channels/fast-4.2.yaml:- 4.2.28
channels/fast-4.3.yaml:- 4.2.28+amd64
channels/stable-4.2.yaml:- 4.2.28
channels/stable-4.3.yaml:- 4.2.28+amd64If we promote 4.2.28 into candidate-4.3 for the remaining arches, we'll presumably follow through for fast-4.3 and stable-4.3. I'm in favor of that. But there are currently amd64 edges from 4.2.28 to 4.3: $ CHANNEL=candidate-4.3 ~/src/openshift/cincinnati/hack/available-updates.sh 4.2.28
4.2.29 quay.io/openshift-release-dev/ocp-release@sha256:3bff53ce2202ec59ed87581106b05f364fea0e7459f5806e4dc6e5129f130b36 https://access.redhat.com/errata/RHBA-2020:1450
4.2.30 quay.io/openshift-release-dev/ocp-release@sha256:29901303c0c0127b29869b712d54d2da3009dcf9fddd66e3a9d89590cbb8633f https://access.redhat.com/errata/RHBA-2020:1547
4.2.32 quay.io/openshift-release-dev/ocp-release@sha256:fd3bec5564d1989c5e4321a4c730dbb384f45c61cfb8cb3679930e790e7ac5f1 https://access.redhat.com/errata/RHBA-2020:2023
4.2.33 quay.io/openshift-release-dev/ocp-release@sha256:52e780ccc7e3af73b11dcb4afe275e2e743b59ccea6f228089ac93337de244d7 https://access.redhat.com/errata/RHBA-2020:2023
4.3.15 quay.io/openshift-release-dev/ocp-release@sha256:0e9642d28c12f5f54c1ab0fffbfd866daa6179a900e745a935f17f8e6e1e28fc https://access.redhat.com/errata/RHBA-2020:1529
4.3.17 quay.io/openshift-release-dev/ocp-release@sha256:1bc57b872cb878d8cfa43da4da30726d8367f8439934cd35797bde5fbaa76f15 https://access.redhat.com/errata/RHBA-2020:1529
4.3.18 quay.io/openshift-release-dev/ocp-release@sha256:1f0fd38ac0640646ab8e7fec6821c8928341ad93ac5ca3a48c513ab1fb63bc4b https://access.redhat.com/errata/RHBA-2020:1529
4.3.19 quay.io/openshift-release-dev/ocp-release@sha256:28c451bfb531e5af71332a933073a2d97673ed157150bacb014a4358501f05ad https://access.redhat.com/errata/RHBA-2020:2006If we turn out to have stability issues on those 4.2->4.3 edges that are unique to non-amd64 arches, we'd need to pull edges for all arches (because we currently don't have #171 or similar way to pull edges only for subsets of clusters). So this should get some nice, long cook time in candidate before they go into fast ;). /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sosiouxme, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…f arch They went into candidate without architecture qualifiers in 0157b7b (Merge pull request openshift#229 from sosiouxme/patch-5, 2020-05-08) with an explicit decision to go multi-arch in db17a23 (candidate-4.3: allow multi-arch 4.2 s390x upgrades, 2020-05-05, openshift#229). But for some reason had arch guards when they went into fast with cb27d43 (Add 4.2.28 to fast, 2020-04-08, openshift#162) and 9d10713 (Add 4.2.29 to fast, 2020-04-15, openshift#178) and stable with 74b433b (Add 4.2.28 to stable, 2020-04-08, openshift#163) f652963 (Add 4.2.29 to stable, 2020-04-15, openshift#179).
…f arch They went into candidate without architecture qualifiers in 0157b7b (Merge pull request openshift#229 from sosiouxme/patch-5, 2020-05-08) with an explicit decision to go multi-arch in db17a23 (candidate-4.3: allow multi-arch 4.2 s390x upgrades, 2020-05-05, openshift#229). But for some reason had arch guards when they went into fast with cb27d43 (Add 4.2.28 to fast, 2020-04-08, openshift#162) and 9d10713 (Add 4.2.29 to fast, 2020-04-15, openshift#178) and stable with 74b433b (Add 4.2.28 to stable, 2020-04-08, openshift#163) f652963 (Add 4.2.29 to stable, 2020-04-15, openshift#179).
https://coreos.slack.com/archives/CB95J6R4N/p1588689093421200?thread_ts=1588687463.420800&cid=CB95J6R4N for background