Skip to content

Conversation

@thiagoalessio
Copy link
Member

No description provided.

@wking
Copy link
Member

wking commented Apr 15, 2020

/hold

Blocked on #178 and cook time.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 15, 2020
@wking
Copy link
Member

wking commented Apr 20, 2020

We want this so we still have stable 4.2 -> 4.3 edges after #184 lands. Checking Telemetry, there are no concerning updates into or out of 4.2.29, and #178 has landed, so:

/hold cancel
/lgtm

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 20, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: thiagoalessio, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 20, 2020
@openshift-merge-robot openshift-merge-robot merged commit 220f08f into openshift:master Apr 20, 2020
wking added a commit to wking/cincinnati-graph-data that referenced this pull request Jul 1, 2020
…f arch

They went into candidate without architecture qualifiers in 0157b7b
(Merge pull request openshift#229 from sosiouxme/patch-5, 2020-05-08) with an
explicit decision to go multi-arch in db17a23 (candidate-4.3: allow
multi-arch 4.2 s390x upgrades, 2020-05-05, openshift#229).  But for some reason
had arch guards when they went into fast with cb27d43 (Add 4.2.28
to fast, 2020-04-08, openshift#162) and 9d10713 (Add 4.2.29 to fast,
2020-04-15, openshift#178) and stable with 74b433b (Add 4.2.28 to stable,
2020-04-08, openshift#163) f652963 (Add 4.2.29 to stable, 2020-04-15, openshift#179).
wking added a commit to wking/cincinnati-graph-data that referenced this pull request Apr 1, 2021
…f arch

They went into candidate without architecture qualifiers in 0157b7b
(Merge pull request openshift#229 from sosiouxme/patch-5, 2020-05-08) with an
explicit decision to go multi-arch in db17a23 (candidate-4.3: allow
multi-arch 4.2 s390x upgrades, 2020-05-05, openshift#229).  But for some reason
had arch guards when they went into fast with cb27d43 (Add 4.2.28
to fast, 2020-04-08, openshift#162) and 9d10713 (Add 4.2.29 to fast,
2020-04-15, openshift#178) and stable with 74b433b (Add 4.2.28 to stable,
2020-04-08, openshift#163) f652963 (Add 4.2.29 to stable, 2020-04-15, openshift#179).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants