Skip to content

Conversation

@wking
Copy link
Member

@wking wking commented Jul 1, 2020

They went into candidate without architecture qualifiers in 0157b7b (#229) with an explicit decision to go multi-arch in db17a23. But for some reason had arch guards when they went into fast with cb27d43 (#162) and 9d10713 (#178) and stable with 74b433b (#163) f652963 (#179).

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 1, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 1, 2020

@wking: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/publish 10b2c24 link /test publish

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@LalatenduMohanty
Copy link
Member

LalatenduMohanty commented Jul 2, 2020

They went into candidate without architecture qualifiers in 0157b7b (#229) with an explicit decision to go multi-arch in db17a23. But for some reason had arch guards when they went into fast with cb27d43 (#162) and 9d10713 (#178) and stable with 74b433b (#163) f652963 (#179).

The decision to go muti-arch #229 was done later i.e. after we merged x86_64 specific edges to fast and stable. ART need to send 3 PRs (i.e. candidate, fast and stable) at one go. So that we will not put our-self in this position again.

@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 5, 2021
@openshift-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci-robot openshift-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 4, 2021
@openshift-bot
Copy link
Contributor

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci-robot
Copy link

@openshift-bot: Closed this PR.

Details

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking
Copy link
Member Author

wking commented Apr 1, 2021

/reopen

@openshift-ci-robot
Copy link

@wking: Reopened this PR.

Details

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 1, 2021
…f arch

They went into candidate without architecture qualifiers in 0157b7b
(Merge pull request openshift#229 from sosiouxme/patch-5, 2020-05-08) with an
explicit decision to go multi-arch in db17a23 (candidate-4.3: allow
multi-arch 4.2 s390x upgrades, 2020-05-05, openshift#229).  But for some reason
had arch guards when they went into fast with cb27d43 (Add 4.2.28
to fast, 2020-04-08, openshift#162) and 9d10713 (Add 4.2.29 to fast,
2020-04-15, openshift#178) and stable with 74b433b (Add 4.2.28 to stable,
2020-04-08, openshift#163) f652963 (Add 4.2.29 to stable, 2020-04-15, openshift#179).
@wking wking force-pushed the arch-agnostic-4.2.28-to-fast-4.3 branch from 10b2c24 to 6b94854 Compare April 1, 2021 01:37
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 1, 2021
@wking
Copy link
Member Author

wking commented Apr 1, 2021

Rebased onto master with 10b2c24 -> 6b94854 to address:

$ hack/stabilization-changes.py
INFO: considering promotions from candidate-4.3 to fast-4.3 after P1W
INFO:   recommended: 4.2.28 (142 days, 7:30:27.122771)
DEBUG:     channels/fast-4.3: Promote 4.2.28 to fast-4.3
DEBUG:     It was promoted the feeder candidate-4.3 by 0d960959e4 (Merge pull request #526 from sdodson/backfill-stable-previous-minors, 2020-11-09).
INFO:   recommended: 4.2.29 (327 days, 3:26:31.122771)
DEBUG:     channels/fast-4.3: Promote 4.2.29 to fast-4.3
DEBUG:     It was promoted the feeder candidate-4.3 by 0157b7b6e2 (Merge pull request #229 from sosiouxme/patch-5, 2020-05-08).
...

for #75.

@LalatenduMohanty
Copy link
Member

/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LalatenduMohanty, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [LalatenduMohanty,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 1, 2021
@openshift-merge-robot openshift-merge-robot merged commit 03956b2 into openshift:master Apr 1, 2021
@wking wking deleted the arch-agnostic-4.2.28-to-fast-4.3 branch April 1, 2021 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants