Skip to content

Conversation

@wking
Copy link
Member

@wking wking commented Apr 13, 2020

We don't know why we started seeing this in 4.3.10, and installer defaults for Azure CPU capacity haven't changed between 4.2 and 4.3, but I'm pushing this up as a mock up of what "block this edge for some types of clusters" might look like.

We don't know why we started seeing this in 4.3.10, and installer
defaults for Azure CPU capacity haven't changed between 4.2 and 4.3,
but I'm pushing this up as a mock up of what "block this edge for some
types of clusters" might look like.
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 13, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wking
To complete the pull request process, please assign crawford
You can assign the PR to them by writing /assign @crawford in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wking
Copy link
Member Author

wking commented Apr 13, 2020

/hold

Just to be extra sure that we don't land this mock up ;).

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 13, 2020
@openshift-ci-robot
Copy link

@wking: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 21, 2020
@wking
Copy link
Member Author

wking commented Aug 7, 2020

I've translated from this brief sketch (which didn't generate much interest) into a formal enhancement with openshift/enhancements#426.

/close

@openshift-ci-robot
Copy link

@wking: Closed this PR.

Details

In response to this:

I've translated from this brief sketch (which didn't generate much interest) into a formal enhancement with openshift/enhancements#426.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking
Copy link
Member Author

wking commented Sep 10, 2021

#1056 should be the real deal :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants