OCPBUGS-20097: Use RHEL8 oc explicitly

[ardaguclu]

Previous PR #4000 was reverted in #4002 because changes were not backwards compatible and caused cascading failures.

This PR reintroduces same approach additionally supporting backwards compatibility. Firstly, it checks the path of oc.rhel8. If binary is found, it will copy. If binary is not found like releases older than 4.15, it falls back to current behavior.

Thanks to this change, maintainers of this repository can change rhel version of oc and also supports multiple architecture versions (i.e. linux_arm64).

Edited: I'd like to note the reason of this change is that we are going to change the base image of oc from RHEL8 to RHEL9 and oc compiled in RHEL9 does not work on RHEL8 clusters. Therefore, we have to explicitly use oc RHEL8 binary in ci-tools, until ci-tools is decided to bumped to RHEL9.

[openshift-ci-robot]

@ardaguclu: This pull request explicitly references no jira issue.

Details

In response to this:

Previous PR #4000 was reverted in #4002 because changes did not backwards compatible and cause cascading failures.

This PR reintroduces same approach additionally supporting backwards compatibility. Firstly, it checks the path of oc.rhel8. If binary is found, it will copy. If binary is not found like releases older than 4.15, it falls back to current behavior.

Thanks to this change, maintainers of this repository can change rhel version of oc and also supports multiple architecture versions (i.e. linux_arm64).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

/test remaining-required

[ardaguclu]

seems unrelated failure;
/retest-required

[ardaguclu]

multi_stage tests are passing but e2e failed in pod_scaler test. I don't think, it is related to this PR but we need to ensure.

[ardaguclu]

As seen in this job https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_ci-tools/4007/pull-ci-openshift-ci-tools-master-e2e/1764611836759511040 that was triggered by dummy PR #4007, e2e job is broken.

[ardaguclu]

/retest-required

[ardaguclu]

e2e test successfully passed against 4.13 images https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_ci-tools/4006/pull-ci-openshift-ci-tools-master-e2e/1764620755875663872 which proves that fall back mechanism works against older versions.

[openshift-ci-robot]

/test remaining-required

[ardaguclu]

e2e test successfully passed against 4.15 image https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_ci-tools/4006/pull-ci-openshift-ci-tools-master-e2e/1764653723851689984 which proves that the patch works against clusters >= 4.15

[openshift-ci-robot]

@ardaguclu: This pull request explicitly references no jira issue.

Details

In response to this:

Previous PR #4000 was reverted in #4002 because changes were not backwards compatible and caused cascading failures.

This PR reintroduces same approach additionally supporting backwards compatibility. Firstly, it checks the path of oc.rhel8. If binary is found, it will copy. If binary is not found like releases older than 4.15, it falls back to current behavior.

Thanks to this change, maintainers of this repository can change rhel version of oc and also supports multiple architecture versions (i.e. linux_arm64).

Edited: I'd like to note the reason of this change is that we are going to change the base image of oc from RHEL8 to RHEL9 and oc compiled in RHEL9 does not work on RHEL8 clusters. Therefore, we have to explicitly use oc RHEL8 binary in ci-tools, until ci-tools is decided to bumped to RHEL9.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@ardaguclu: This pull request references Jira Issue OCPBUGS-20097, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.16.0) matches configured target version for branch (4.16.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Previous PR #4000 was reverted in #4002 because changes were not backwards compatible and caused cascading failures.

This PR reintroduces same approach additionally supporting backwards compatibility. Firstly, it checks the path of oc.rhel8. If binary is found, it will copy. If binary is not found like releases older than 4.15, it falls back to current behavior.

Thanks to this change, maintainers of this repository can change rhel version of oc and also supports multiple architecture versions (i.e. linux_arm64).

Edited: I'd like to note the reason of this change is that we are going to change the base image of oc from RHEL8 to RHEL9 and oc compiled in RHEL9 does not work on RHEL8 clusters. Therefore, we have to explicitly use oc RHEL8 binary in ci-tools, until ci-tools is decided to bumped to RHEL9.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[danilo-gemoli]

/lgtm
/hold
@ardaguclu unhold whenever you feel ready

[ardaguclu]

@danilo-gemoli thanks for tagging. Before unholding, I'd like to have review from @soltysh to lower the possibility of issues that happened in #4000

[soltysh]

/lgtm
probably worth re-trying the merges after the shift week

[joepvd]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, danilo-gemoli, joepvd, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [danilo-gemoli]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ardaguclu]

/hold cancel

[openshift-ci]

@ardaguclu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/security	b70d1f1	link	false	/test security

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD e036514 and 2 for PR HEAD b70d1f1 in total

[openshift-ci-robot]

@ardaguclu: Jira Issue OCPBUGS-20097: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

• openshift/release#47661 is open

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-20097 has not been moved to the MODIFIED state.

Details

In response to this:

Previous PR #4000 was reverted in #4002 because changes were not backwards compatible and caused cascading failures.

This PR reintroduces same approach additionally supporting backwards compatibility. Firstly, it checks the path of oc.rhel8. If binary is found, it will copy. If binary is not found like releases older than 4.15, it falls back to current behavior.

Thanks to this change, maintainers of this repository can change rhel version of oc and also supports multiple architecture versions (i.e. linux_arm64).

Edited: I'd like to note the reason of this change is that we are going to change the base image of oc from RHEL8 to RHEL9 and oc compiled in RHEL9 does not work on RHEL8 clusters. Therefore, we have to explicitly use oc RHEL8 binary in ci-tools, until ci-tools is decided to bumped to RHEL9.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.