Skip to content

Conversation

@j-griffith
Copy link

Add CSIBlockVolume and BlockVolume feature gates to the API. Requesting to add this for support in 4.1 in order to enable planned presentations for RH Summit. Let me know if there is a special feature exception process I need to follow.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 5, 2019
@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 5, 2019
@openshift-ci-robot
Copy link

Hi @j-griffith. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@deads2k
Copy link
Contributor

deads2k commented Apr 8, 2019

/hold

This must be approved via the exception process including PM, architecture, and QE. This expands our test, product, and support surface area.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 8, 2019
"RotateKubeletServerCertificate", // sig-pod, sjenning
"SupportPodPidsLimit", // sig-pod, sjenning
"CSIBlockVolume", // sig-storage, j-griffith
"BlockVolume", // sig-storage, j-griffith
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

certainly a NAK on these changes. We are not going to make these available by default out of the box.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's certainly fair, I'll remove them from the default set; there was some confusion (on my part) whether they were required to be there or not, I will remove if we can reach agreement on the remaining piece. Thanks!

@j-griffith j-griffith force-pushed the add_csi_block_volume branch from d5096f5 to 3314993 Compare April 8, 2019 14:11
Add CSIBlockVolume and BlockVolume feature gates to the API.
@j-griffith j-griffith force-pushed the add_csi_block_volume branch from 3314993 to 6a702b5 Compare April 8, 2019 14:53
@childsb
Copy link

childsb commented Apr 8, 2019

We aren't shipping the CSI shim layers in 4.1 so there's no official CSI block support. This would only be available in-house.

Functionally this won't impact other features or be visible to customers. This is low risk +1 for the exception.

@eparis
Copy link
Member

eparis commented Apr 8, 2019

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 8, 2019
@eparis
Copy link
Member

eparis commented Apr 8, 2019

/ok-to-test

@openshift-ci-robot openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 8, 2019
@eparis
Copy link
Member

eparis commented Apr 8, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 8, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eparis, j-griffith

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2019
@openshift-merge-robot openshift-merge-robot merged commit 6d14d1b into openshift:master Apr 8, 2019
@eparis
Copy link
Member

eparis commented Apr 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants