Skip to content

bootstrap: add featuregate CR #1546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
deads2k wants to merge 2 commits into from
Closed

bootstrap: add featuregate CR #1546

deads2k wants to merge 2 commits into from

Conversation

@deads2k
Copy link
Contributor

@deads2k deads2k commented Apr 8, 2019

Config resources need to exist to kick off many operators. Most of these should never be misssing.
FeatureGate is one such example that we should always have and we prevent its deletion.

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 8, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 8, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deads2k
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: flaper87

If they are not already assigned, you can assign the PR to them by writing /assign @flaper87 in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deads2k
Copy link
Contributor Author

deads2k commented Apr 8, 2019

/hold

I think I found past-me's pull making this kind of work from cluster-config-operator

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 8, 2019
@deads2k
Copy link
Contributor Author

deads2k commented Apr 8, 2019

openshift/cluster-config-operator#15 may get the job done for initial creation

@deads2k deads2k mentioned this pull request Apr 8, 2019
Merged
staebler
staebler reviewed Apr 8, 2019
View reviewed changes
pkg/asset/manifests/featuregate.go Outdated
Copy link
Contributor

@staebler staebler Apr 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The InstallConfig dependency is unnecessary.

Copy link
Contributor Author

@deads2k deads2k Apr 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The InstallConfig dependency is unnecessary.

removing it appears to have caused multiple failures.

Copy link
Contributor

@staebler staebler Apr 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should have been more complete with my comment. You need to also remove the code in Generate where the InstallConfig is retrieved.

https://github.com/openshift/installer/blob/5b62a4df18af00285191b512b3965fd55fb3611c/pkg/asset/manifests/featuregate.go#L38-L39

Copy link
Contributor Author

@deads2k deads2k Apr 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should have been more complete with my comment. You need to also remove the code in Generate where the InstallConfig is retrieved.

and now I feel slow.

@deads2k
bootstrap: add featuregate CR
9a06478 
Config resources need to exist to kick off many operators.  Most of these should never be misssing.
FeatureGate is one such example that we should always have and we prevent its deletion.
@openshift-ci-robot openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 8, 2019
@rphillips rphillips mentioned this pull request Apr 8, 2019
Merged
@deads2k
Copy link
Contributor Author

deads2k commented Apr 8, 2019

/retest

1 similar comment
@deads2k
Copy link
Contributor Author

deads2k commented Apr 9, 2019

/retest

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 9, 2019

@deads2k: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws 1c639e2 link /test e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@deads2k deads2k mentioned this pull request Apr 9, 2019
Closed
@eparis
Copy link
Member

eparis commented Apr 9, 2019

openshift/api#278

@deads2k
Copy link
Contributor Author

deads2k commented Apr 9, 2019

alright, given the stuck MCD issue, I'm going down a path of modifying the CVO to handle our use-case

@deads2k deads2k closed this Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abhinavdahiya abhinavdahiya Awaiting requested review from abhinavdahiya

@hardys hardys Awaiting requested review from hardys

1 more reviewer

@staebler staebler staebler left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@deads2k @openshift-ci-robot @eparis @staebler