Skip to content

Conversation

@bertinatto
Copy link
Member

CSIBlockVolume support was enabled in 4.1 via this PR: #278

This feature is alpha in k8s v1.13 (Openshift 4.1), however, the feature turned beta in v1.14 (which 4.2 is based on).

Since we're looking into making this feature generally available for Openshift 4.2, I believe we should remove this line from the tech preview list of features.

CC @j-griffith, @humblec, @jarrpa, @openshift/storage

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 3, 2019
@bertinatto
Copy link
Member Author

/assign @eparis

@humblec
Copy link

humblec commented Jul 3, 2019

LGTM !! Thanks @bertinatto

@bertinatto
Copy link
Member Author

@eparis, can you check if this makes sense, please?

@bertinatto
Copy link
Member Author

/assign @deads2k @sttts

@deads2k
Copy link
Contributor

deads2k commented Jul 11, 2019

/lgtm

You'll need to bump the operators of affected binaries and whatever drives the kubelet.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 11, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, deads2k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 11, 2019
@openshift-merge-robot openshift-merge-robot merged commit cf189d3 into openshift:master Jul 11, 2019
@bertinatto
Copy link
Member Author

OK, checking which components I need to bump.

@eparis
Copy link
Member

eparis commented Jul 11, 2019

I don't think we really care if they get bumped. Since this is enabled by default in 4.2 having this present or not is irrelevant, no?

@bertinatto
Copy link
Member Author

I don't think we really care if they get bumped. Since this is enabled by default in 4.2 having this present or not is irrelevant, no?

After looking into this for a while, that's my understanding as well.

As far as I understand, it would be relevant if it was the other way around (enabling a previously disabled feature, for example). @deads2k, are we missing anything here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants