Skip to content

Conversation

@rphillips
Copy link
Contributor

Includes new featureflag: CSIBlockVolume.

/cc @deads2k

@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 9, 2019
@eparis
Copy link
Member

eparis commented Apr 9, 2019

openshift/api#278

@deads2k
Copy link
Contributor

deads2k commented Apr 9, 2019

This appears to be orthogonal, but I don't mind it. You actually need all the operators to honor that value. Most do not yet.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 9, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, rphillips

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 9, 2019
@openshift-merge-robot openshift-merge-robot merged commit 5364122 into openshift:master Apr 9, 2019
eparis pushed a commit to eparis/client-go that referenced this pull request Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants