Skip to content

Conversation

@deads2k
Copy link
Contributor

@deads2k deads2k commented Apr 9, 2019

rebump and add the library-go feature gate function

@deads2k deads2k added the lgtm Indicates that a PR is ready to be merged. label Apr 9, 2019
@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 9, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 9, 2019
@deads2k
Copy link
Contributor Author

deads2k commented Apr 9, 2019

e2e is almost done. If it's green, I'll push one on top of this and force merge after green verify. If it's not, I'll push and wait.

@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 9, 2019
@deads2k deads2k added the lgtm Indicates that a PR is ready to be merged. label Apr 9, 2019
@openshift-merge-robot openshift-merge-robot merged commit 287f3cc into openshift:master Apr 9, 2019
@eparis
Copy link
Member

eparis commented Apr 10, 2019

openshift/api#278

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants