Changes made since Xavier's last review - #21
Closed
martynjames wants to merge 18 commits into
Closed
Conversation
Analytics fixes + alt description for google images
…escribed how someone can get test coverage in README file
Fixed unit tests to run on the newest version of workbench - merging into clean_up branch
…e test coverage report to only include google_drive
pep8 and pylint should be supported and runable on Travis; changed the t... merging to run on travis
…ween the 2 XBlock components herein - better to have a common pattern than to seprate out these lines. Also use virtual display to support selenium tests in travis.
Clean up and reorganization
Changes as a result of feedback
martynjames
changed the title
There was a problem hiding this comment.
Thanks for adding the integration tests! It would be worth adding tests for the Studio views - we recently figured out how to do them from the workbench, If you want an example see https://github.com/mckinseyacademy/xblock-poll/blob/master/tests/integration/test_studio.py
|
@martynjames @marjev A few comments, but once addressed I'm 👍 |
Feedback inspired changes
Added integration tests for studio views; Code clean-up;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@antoviaque - here's a PR for comments since your last review