Skip to content

Fixed unit tests to run on the newest version of workbench - #15

Merged
martynjames merged 4 commits into
clean_upfrom
mjevtic/SOL-299
Feb 3, 2015
Merged

Fixed unit tests to run on the newest version of workbench#15
martynjames merged 4 commits into
clean_upfrom
mjevtic/SOL-299

Conversation

@marjev

@marjev marjev commented Feb 2, 2015

Copy link
Copy Markdown
Contributor

@martynjames

This should fix issue SOL-299.

Comment thread google_drive/tests/unit/test_docs.py Outdated

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line is too long, may have to split it up a little more (123 chars)

@martynjames

Copy link
Copy Markdown

The aim here is to have the tests working in their own environment, so we cannot depend upon stuff already present in edx-platform dependencies. The requirements.txt file may need to be updated, and it's possible that other dependencies still need to be added to get the tests up and running.

Try running it in a new mkvirtualenv, with pip install -r requirements.txt - this will need to run. I just built a clean one 'cos I might have screwed up the previous run

Comment thread .travis.yml

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet! - we need a few things added in here:
Calling pep8 checks
Calling pylint checks
After running tests, we need to run the coverage report.

Once you've got that running we may need to increase the coverage if we are missing a lot ;-)

Please take a look at https://github.com/edx/edx-milestones/blob/master/.travis.yml for a good example

martynjames pushed a commit that referenced this pull request Feb 3, 2015
Fixed unit tests to run on the newest version of workbench - merging into clean_up branch
@martynjames
martynjames merged commit 86f99fc into clean_up Feb 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants