Changes as a result of feedback - #20
Merged
Merged
Conversation
|
LGTM! Thanks for addressing the two main concerns -- moving the refs/hashes to something more readable/accessible and splitting out the calendar tests. 👍 |
martynjames
pushed a commit
that referenced
this pull request
Feb 6, 2015
Changes as a result of feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@mattdrayer - Some changes as a result of your feedback... I ignored moving some of the things (like default calendar_id, etc.) into configuration settings, as we don't seem to have a standard for doing that for XBlocks yet.