Develop to main. Release v2 #538

IvanStepanok · 2024-11-06T14:05:37Z

Features

Split Account Settings and Profile views (#397)
Add alert for outdated course calendars on home screen
Synchronize course calendar design (#439)
Enhance Dashboard navigation and layout (#434)
Enable course progress tracking with collapsible sections (#446)
Introduce calendar synchronization and FCM for notifications (#466)
Integrate FullStory and analytics capabilities (#471)
Implement relative dates in UI (#505)
Add offline mode for xBlocks (#474)
SAML-based single sign-on (#447)
Migrate iOS build to iOS 18 (#525)
Introduce iOS Mobile Plugin Architecture (#528)

Fixes

Default discovery enabled (#433)
Multiple CoreData-related crash fixes (#516, #518)
Fix crashes for SE device header, alerts on iPad, and gallery privacy (#482, #521, #522)
Update EnrollmentsStatus value to recentlyActive (#529)
Offline file deletion improvements (#527)
Synchronize with upstream changes (#526, #533)
Adjust Facebook SDK version for compatibility (#537)

Chores & Maintenance

Theme enhancements and back button customization
Add settings button for dashboard list view
Localization updates and typo corrections
Fastlane upgrade for CI/CD (#534)

Tests

Add unit tests for DownloadManager, AllCoursesViewModel, and PrimaryCoursesViewModel (#532, #537)

* feat: Separate account settings and profile editing * feat: changes according to desing * feat: update background colors * feat: update missed email value in tests * fix: resume old design * fix: changes after the code review * fix: code formatting on ManageAccountView * fix: changes after code review fix navigation titles and back buttons on few screens * feat: updates after shafqat-muneer code review * feat: fixes after review * feat: changes after code review

chore: Sliding course menu theme enhancement

Added custom back button for downloads view

* chore: player refactor * chore: removed url property * chore: fixed completion and rate view for player * chore: removed commented code * chore: added error handler * chore: refactor * chore: refactor * chore: refactor * chore: refactor * chore: refactor * chore: tests * chore: refactor * chore: review requested changes * chore: merge conflict resolve

(cherry picked from commit daac035)

* feat: calendar synchronization design * fix: address feedback * fix: address feedback * fix: address feedback * fix: address feedback * fix: address feedback * fix: update profile mock file * fix: address feedback * fix: address feedback remove old errorAlertView variables

* feat: replace Discover page with new Learn page * fix: address feedback * fix: address feedback * fix: address feedback * fix: address feedback * fix: address feedback * fix: address feedback * fix: address feedback * fix: change DropDown menu arrow direction * fix: address feedback * fix: address feedback * fix: address feedback * fix: address feedback * fix: address feedback * fix: address feedback * fix: address feedback * fix: address feedback * fix: address feedback * fix: address feedback * fix: address feedback * fix: address feedback * fix: address feedback

* feat: course home navigation * fix: address feedback * fix: merge conflicts * fix: address feedback * fix: address feedback * fix: address feedback * fix: address feedback * fix: address feedback * fix: address feedback * fix: address feedback * fix: address feedback

fix: APIs path and archive fix

Co-authored-by: Anton Yarmolenko <[email protected]>

…#452) * feat: Delete old downloaded videos data on device to optimize storage * chore: resolved failed test cases * chore: address review feedback

Fix video quality settings in modal representation

Fix/progress bar

…el Downloaded Videos #456 (#463) * fix: confirmation alert * chore: changed string to localization * chore: review required changes

* feat: firebase cloud messaging * fix: address feedback * fix: address feedback

* chore: fix double notification routing and segment callback * refactor: address review feedback * refactor: address review feedback

…lations` (#465)

* feat: initial commit * feat: relative dates * fix: address feedback * fix: update tests * fix: address feedback * fix: address feedback * fix: address feedback * fix: address feedback

* feat: course offline mode * Merge branch 'develop' into feat/course-offline-mode * fix: address feedback * fix: address feedback * fix: address feedback * fix: resolve merge conflicts * fix: update mocks * fix: address feedback * fix: address feedback * fix: address feedback * fix: address feedback * fix: address feedback * fix: address feedback

* Merge pull request #22 from edx/fix/PrimaryEnrollment_data fix: quick fix for primary enrolment data * chore: deleted unused parameter for init --------- Co-authored-by: Vadim Kuznetsov <[email protected]> Co-authored-by: Anton Yarmolenko <[email protected]>

Co-authored-by: Vadim Kuznetsov <[email protected]>

Co-authored-by: Saeed Bashir <[email protected]>

* fix: core data crash with inverse attribute (#69) * chore: set deletetionRule as Cascade --------- Co-authored-by: Vadim Kuznetsov <[email protected]> Co-authored-by: Anton Yarmolenko <[email protected]>

Co-authored-by: Saeed Bashir <[email protected]> Co-authored-by: Anton Yarmolenko <[email protected]>

* feat: migrate to ios 18 * fix: updrade ios version on tests * fix: CI --------- Co-authored-by: Volodymyr Chekyrta <[email protected]>

* Merge pull request #23 from edx/small-fix-for-downloading-cancelling fix: fixes for downloading * chore: fix for Xcode 16 and after merge * Merge pull request #24 from edx/2U/fix/download-states fix: [iOS] On Course "Home" tab the row height * fix: after merge, deleted IAP part fix: [iOS] On Course "Home" tab the row height * Merge pull request #25 from edx/2U/feat/primary-horizontal feat: Landscape mode Improvement * fix: removed IAP part * chore: remove snack bar error for course dates info API on course home (#27) * Merge pull request #28 from shafqat-muneer/Shafqat/LEARNER-10020-ErrorHandling feat: Course Level Error Handling for Empty States * chore: remove IAP part after merging --------- Co-authored-by: Anton Yarmolenko <[email protected]> Co-authored-by: Saeed Bashir <[email protected]>

* fix: update DownloadManager.swift * fix: fix the temp data deletion issue * fix: upgrade fastlane --------- Co-authored-by: Volodymyr Chekyrta <[email protected]>

* feat: add single sign on by saml * fix: saml sso fix unit tests * fix: saml sso configuration and UI * fix: saml sso review changes * fix: update default config files for saml sso review changes * fix: update code depending on saml sso review changes * fix: updating sign in sso login title in auth Localizable.strings * fix: remove comma from yaml files * fix: reset default configuration, hide sso login button by default

* Merge pull request #29 from edx/Shafqat/LEARNER-10022-Accessibility chore: Fix Initial Accessibility Testing Issues * chore: auto-generated string * fix: snack bar and resume course button color fix for light dark modes (#34) * Merge pull request #31 from edx/about-blank-links-fix fix: open link in Safari if link has target blank * Merge pull request #36 from edx/Shafqat/AllCoursesFilterFix Fix All Courses Taping Issue --------- Co-authored-by: Anton Yarmolenko <[email protected]> Co-authored-by: Saeed Bashir <[email protected]> Co-authored-by: Vadim Kuznetsov <[email protected]>

* test: add DownloadManager tests * fix: delete old file * fix: add SwiftyMocky to DownloadManager tests * fix: address feedback * fix: updated mock files

* chore: show unsupported error screen for gated content (#37) * chore: string auto-generating * chore: removed unused func * chore: update facebook sdk to solve open(url) issue --------- Co-authored-by: Saeed Bashir <[email protected]> Co-authored-by: Anton Yarmolenko <[email protected]>

…iewModel, CalendarManager (#535)

Co-authored-by: Anton Yarmolenko <[email protected]>

* feat: connect oexfoundation library to project * fix: update library version * fix: change package version * feat: connect OEXFoundation to project * fix: update OEXFoundation library url and version * fix: address feedback * fix: update mocks * fix: update fastline * fix: address feedback * fix: move msal to main module * fix: address feedback

openedx-webhooks · 2024-11-06T14:05:42Z

Thanks for the pull request, @IvanStepanok!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
- This process (including the steps you'll need to take) is documented here.
If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

Dependencies

This PR must be merged before / after / at the same time as ...
Blockers

This PR is waiting for OEP-1234 to be accepted.
Timeline information

This PR must be merged by XX date because ...
Partner information

This is for a course on edx.org.
Supporting documentation
Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/openedx-mobile-maintainers. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

The size and impact of the changes that it introduces
The need for product review
Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

* fix: SE device UI issues (#39) * fix: se device * fix: course image * fix: small course * fix: header for ios 15 * fix: double nav bar * chore: added trophy assets * fix: fixed all courses screen * fix: ipad course dashboard * chore: fixed dates banner padding * fix: ipad upgrade view * chore: fix for rotation bug * fix: scroll on home tab * chore: update introspect for future versions * chore: rename name of file icon * chore: delete unneeded IAP icon * chore: delete IAP part * chore: delete IAP part * chore: fix after merge * chore: started to add courseRawImage * chore: delete IAP part * fix: after merge * chore: deleted unsupported ios 15 modifiers * chore: added courseRawImage * chore: moved progress to correct place * chore: fix broken tests --------- Co-authored-by: Vadim Kuznetsov <[email protected]> Co-authored-by: Anton Yarmolenko <[email protected]>

IvanStepanok and others added 30 commits May 7, 2024 16:14

chore: added custom back button for downloads view

2f99d75

feat: Alert for outdated course calendars on the course home screen

bd9f081

Merge branch 'develop' into add-custom-back-for-downloads-view

2ba7a35

chore: Sliding course menu theme enhancement

102e44c

Merge pull request #431 from saeedbashir/saeed/sliding_bar_theme

83ce168

chore: Sliding course menu theme enhancement

fix: discovery enabled by default (#433)

5305a92

fix: build warnings (#432)

9e18a29

Merge pull request #430 from edx/add-custom-back-for-downloads-view

353f8a0

Added custom back button for downloads view

fix: rtl for "arrowLeft" image in Core/Assets (#440)

4690b1b

(cherry picked from commit daac035)

fix: APIs path and archive fixes

a4a85d5

Merge pull request #450 from saeedbashir/saeed/fixes

0933ddd

fix: APIs path and archive fix

fix: delete local file first since we build url with data from DB (#453)

c39b087

Co-authored-by: Anton Yarmolenko <[email protected]>

chore: added isModal flag

5ef90cf

feat: Delete old downloaded videos data on device to optimize storage (…

3ab245b

…#452) * feat: Delete old downloaded videos data on device to optimize storage * chore: resolved failed test cases * chore: address review feedback

fix: double loading indicator

dc32ffa

feat: atlas push pull scripts: FC-55 (#422)

dcb4134

chore: fixed wrong name

3244d1e

Merge pull request #457 from edx/fix-modal-view-for-quality-settings

daf4834

Fix video quality settings in modal representation

Merge pull request #462 from edx/fix/progressBar

6fec863

Fix/progress bar

fix: download loading indicator (#464)

34cee0d

[iOS] Prompt | Confirmation Alert Missing Before Deleting Section-Lev…

5498a1c

…el Downloaded Videos #456 (#463) * fix: confirmation alert * chore: changed string to localization * chore: review required changes

feat: [FC-0047] FCM (#461)

b2539a6

* feat: firebase cloud messaging * fix: address feedback * fix: address feedback

feat: Program Screen Error Handling (#448)

ea6e24e

chore: added Settings button for dashboard type 'list'

f6c9f47

chore: fix double notification routing and segment callback (#473)

9901340

* chore: fix double notification routing and segment callback * refactor: address review feedback * refactor: address review feedback

OmarIthawi and others added 22 commits August 19, 2024 10:23

feat: remove uk translations and sync xcode project after `pull_trans…

157ded7

…lations` (#465)

feat: [FC-0047] Relative Dates (#505)

a405dce

* feat: initial commit * feat: relative dates * fix: address feedback * fix: update tests * fix: address feedback * fix: address feedback * fix: address feedback * fix: address feedback

fix: picker crash when no elements (#63) (#517)

61b3e37

Co-authored-by: Vadim Kuznetsov <[email protected]>

fix: fix iPad crash of alert controller (#74) (#521)

8dbdcb2

Co-authored-by: Saeed Bashir <[email protected]>

fix: video crashes (#70) (#520)

d5a55fa

Co-authored-by: Saeed Bashir <[email protected]>

fix: fix coredata crash on primary course (#64) (#518)

e85e970

Co-authored-by: Saeed Bashir <[email protected]>

fix: core data crash with inverse attribute (#519)

2433b22

* fix: core data crash with inverse attribute (#69) * chore: set deletetionRule as Cascade --------- Co-authored-by: Vadim Kuznetsov <[email protected]> Co-authored-by: Anton Yarmolenko <[email protected]>

fix: fix gallary privacy policy violation crash (#75) (#522)

391caae

Co-authored-by: Saeed Bashir <[email protected]> Co-authored-by: Anton Yarmolenko <[email protected]>

Feat/migration to ios 18 (#525)

c632a01

* feat: migrate to ios 18 * fix: updrade ios version on tests * fix: CI --------- Co-authored-by: Volodymyr Chekyrta <[email protected]>

Fix: offline file deletion issue (#527)

f5e9989

* fix: update DownloadManager.swift * fix: fix the temp data deletion issue * fix: upgrade fastlane --------- Co-authored-by: Volodymyr Chekyrta <[email protected]>

fix: change EnrollmentsStatus value isActive to recentlyActive (#529)

8cfe33f

test: add unit tests for DownloadManager (#532)

c4fcc19

* test: add DownloadManager tests * fix: delete old file * fix: add SwiftyMocky to DownloadManager tests * fix: address feedback * fix: updated mock files

build: upgrade fastlane version (#534)

af2ba21

test: AllCoursesViewModel, PrimaryCoursesViewModel, DatesAndCalendarV…

f7eeae8

…iewModel, CalendarManager (#535)

fix: decrease facebook sdk version and fix open(url) calling (#537)

a38730c

Co-authored-by: Anton Yarmolenko <[email protected]>

openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 6, 2024

volodymyr-chekyrta changed the title ~~chore: merge develop into main~~ Develop to main. Release v2 Nov 6, 2024

volodymyr-chekyrta self-requested a review November 6, 2024 14:12

rnr and others added 2 commits November 7, 2024 16:00

build: update action versions (#541)

255e2b7

volodymyr-chekyrta approved these changes Nov 11, 2024

View reviewed changes

volodymyr-chekyrta merged commit ca40c1e into main Nov 11, 2024
9 of 10 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Develop to main. Release v2 #538

Develop to main. Release v2 #538

IvanStepanok commented Nov 6, 2024

openedx-webhooks commented Nov 6, 2024

Develop to main. Release v2 #538

Develop to main. Release v2 #538

Conversation

IvanStepanok commented Nov 6, 2024

Features

Fixes

Chores & Maintenance

Tests

openedx-webhooks commented Nov 6, 2024

What's next?

🔘 Get product approval

🔘 Provide context

🔘 Get a green build

🔘 Let us know that your PR is ready for review:

Who will review my changes?

Where can I find more information?

When can I expect my changes to be merged?