Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Part 2 sync to upstream #530

Merged
merged 5 commits into from
Oct 28, 2024

Conversation

rnr
Copy link
Contributor

@rnr rnr commented Oct 22, 2024

This batch contains next fixes:

  1. Fix Initial Accessibility Testing Issues
    (organized some accessibility labels and moved ‘Dates & Calendar’ into localization)
    chore: Fix Initial Accessibility Testing Issues edx/edx-mobile-marketplace-ios#29
  2. Update offline bar style fix: snack bar and resume course button color fix for light dark modes edx/edx-mobile-marketplace-ios#34
  3. Open link in Safari if link has target=”blank” - fix some links opening
    fix: open link in Safari if link has target blank edx/edx-mobile-marketplace-ios#31
  4. Fix All Courses Taping Issue - filters “All”, “In progress” etc work buggy
    Fix All Courses Taping Issue edx/edx-mobile-marketplace-ios#36

all changes are approved by @marcotuts in this document

@volodymyr-chekyrta
Copy link
Contributor

@IvanStepanok will provide a review for this PR.

Copy link
Contributor

@IvanStepanok IvanStepanok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@volodymyr-chekyrta volodymyr-chekyrta merged commit d7ad72a into openedx:develop Oct 28, 2024
6 checks passed
@rnr rnr deleted the part-2-sync-to-upstream branch November 22, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants