Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: RTL arrowLeft in core assets #440

Merged

Conversation

RawanMatar89
Copy link
Contributor

@RawanMatar89 RawanMatar89 commented May 19, 2024

New contributor

I'm Rawan Matar, from ZeitLabs.
I start working on supporting RTL in OpenEdx iOS app, and this is the first change in my plan.

Description

changed the direction attribute of the "arrowLeft" image in Core/Assets.

Screenshots

Before After
IMG_3090 IMG_3087

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label May 19, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented May 19, 2024

Thanks for the pull request, @RawanMatar89! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@RawanMatar89 RawanMatar89 changed the title RTL arrowLeft in core assets fix: RTL arrowLeft in core assets May 19, 2024
@RawanMatar89 RawanMatar89 marked this pull request as ready for review May 19, 2024 09:14
@RawanMatar89 RawanMatar89 changed the base branch from main to develop May 19, 2024 09:43
@volodymyr-chekyrta volodymyr-chekyrta self-requested a review May 22, 2024 07:24
Copy link
Contributor

@volodymyr-chekyrta volodymyr-chekyrta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @RawanMatar89, thank you for your contribution!
LGTM 👍

@volodymyr-chekyrta volodymyr-chekyrta merged commit 4690b1b into openedx:develop May 22, 2024
3 checks passed
@openedx-webhooks
Copy link

@RawanMatar89 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@OmarIthawi
Copy link
Member

Thanks @RawanMatar89 and @volodymyr-chekyrta!! We're looking forward for more fixes in regards to RTL and SAML.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants