fix: Part 3 sync to upstream #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvanStepanok
suggested changes
Oct 29, 2024
There was a problem hiding this comment.
Great job @rnr ! I only found one bug, everything else looks great!
| .padding(.top, 12) | ||
| StyledButton(CourseLocalization.NotAvaliable.button, action: { | ||
| if let url = URL(string: url), UIApplication.shared.canOpenURL(url) { | ||
| UIApplication.shared.open(url) |
There was a problem hiding this comment.
The link does not open on the simulator and iOS 18 device.
BUG IN CLIENT OF UIKIT: The caller of UIApplication.openURL(:) needs to migrate to the non-deprecated UIApplication.open(:options:completionHandler:). Force returning false (NO).
There was a problem hiding this comment.
Nice catch @IvanStepanok !
This is caused by a Facebook SDK bug. To solve the problem, increase its version. Please re-check
Thank you
volodymyr-chekyrta
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains synchronisation code to solve a problem where a course has gated content and user tap in coursework doesn't work (e.g. ‘IBM's The Data Science Method’ course and some of the graded quizzes in it).
original PR: edx#37
After fix we show page:
