Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert all instrumentation to the new Instrumenter API #2713

Closed
99 tasks done
trask opened this issue Apr 3, 2021 · 8 comments · Fixed by #4973
Closed
99 tasks done

Convert all instrumentation to the new Instrumenter API #2713

trask opened this issue Apr 3, 2021 · 8 comments · Fixed by #4973
Labels
contribution welcome Request makes sense, maintainers probably won't have time, contribution would be welcome enhancement New feature or request

Comments

@trask
Copy link
Member

trask commented Apr 3, 2021 •
edited
Loading

Tracking/discussion issue for converting new instrumentation to the Instrumenter API defined in #2596.

Please add your name next to any that you are working on to avoid duplication. If you don't ability to update this comment, please comment below and someone will update it (you don't need to wait until someone updates the comment to work on it).
@trask trask added the enhancement New feature or request label Apr 3, 2021
This was referenced Apr 3, 2021
Closed
Closed
Closed
Closed
@mateuszrzeszutek mateuszrzeszutek mentioned this issue Apr 6, 2021
Merged
@mateuszrzeszutek mateuszrzeszutek mentioned this issue Apr 14, 2021
Merged
@trask trask mentioned this issue Apr 29, 2021
Closed
This was referenced May 16, 2021
Merged
Merged
@mateuszrzeszutek mateuszrzeszutek mentioned this issue May 20, 2021
Closed
This was referenced May 23, 2021
Merged
Merged
@dengliming
Copy link
Member

methods #3070
redisson-3.0 #3069

@michaelbannister
Copy link
Contributor

I intend to have a go at okhttp/okhttp-3.0 this week

@jonatan-ivanov jonatan-ivanov mentioned this issue May 26, 2021
Closed
@robododge robododge mentioned this issue Jun 15, 2021
Merged
@jonatan-ivanov jonatan-ivanov mentioned this issue Jul 6, 2021
Closed
This was referenced Jul 9, 2021
Merged
Closed
@HaloFour
Copy link
Contributor

HaloFour commented Jul 17, 2021 •
edited
Loading

I'll take a stab at converting WithSpanAspect under spring-boot-autoconfigure.

See #3607

I can follow that up with opentelemetry-annotations-1.0.

@trask trask mentioned this issue Jul 30, 2021
Merged
@mateuszrzeszutek mateuszrzeszutek mentioned this issue Aug 6, 2021
Merged
@jack-berg jack-berg mentioned this issue Aug 6, 2021
Merged
@trask trask mentioned this issue Aug 7, 2021
Merged
@laurit laurit mentioned this issue Aug 9, 2021
Merged
@mateuszrzeszutek mateuszrzeszutek mentioned this issue Aug 9, 2021
Merged
This was referenced Aug 13, 2021
Merged
Merged
@mateuszrzeszutek mateuszrzeszutek mentioned this issue Sep 30, 2021
Merged
@iNikem iNikem mentioned this issue Oct 11, 2021
Closed
@mateuszrzeszutek mateuszrzeszutek mentioned this issue Oct 11, 2021
Merged
@jack-berg jack-berg mentioned this issue Oct 12, 2021
Merged
This was referenced Oct 13, 2021
Merged
Merged
Merged
Merged
Merged
@iNikem
Copy link
Contributor

iNikem commented Oct 20, 2021

@shivanshu1333 Do you still plan to convert Play instrumentations? We are approaching the finishing line and want to close this ticket soon.

@shivanshuraj1333
Copy link
Member

Hey @iNikem, yes I'll raise PRs soon

This was referenced Oct 21, 2021
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Nov 3, 2021
Merged
Merged
Merged
@laurit laurit mentioned this issue Nov 4, 2021
Merged
@trask
Copy link
Member Author

trask commented Nov 5, 2021

Hey @iNikem, yes I'll raise PRs soon

@shivanshu1333 if you can send PR(s) by end of next week that would be great, otherwise let's give those two tasks back to the pool so someone else can pick them up 👍

@shivanshuraj1333 shivanshuraj1333 mentioned this issue Nov 10, 2021
Closed
@laurit laurit mentioned this issue Dec 9, 2021
Merged
@laurit laurit mentioned this issue Dec 23, 2021
Merged
@jamesmoessis
Copy link
Contributor

🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contribution welcome Request makes sense, maintainers probably won't have time, contribution would be welcome enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Convert camel instrumentation to instrumenter api laurit/opentelemetry-java-instrumentation
8 participants
@michaelbannister @trask @iNikem @dengliming @HaloFour @shivanshuraj1333 @jamesmoessis @mateuszrzeszutek