Migrate RMI instrumentation to Instrumenter API #4579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszrzeszutek
requested review from
anuraaga,
iNikem,
jkwatson,
laurit,
pavolloffay,
trask and
tylerbenson
as code owners
99 tasks
trask
approved these changes
Nov 3, 2021
Comment on lines
+51
to
+55
| // TODO replace with client span check - this is a bit different condition though, can we | ||
| // remove it? | ||
| if (!Java8BytecodeBridge.spanFromContext(parentContext).getSpanContext().isValid()) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
looks like tests pass without it. +1 to remove 🤷♂️
There was a problem hiding this comment.
But this is very different condition, no? I read it that we don't want to create top level spans for rmi calls. Nothing in our instrumenters does such check.
iNikem
reviewed
Nov 4, 2021
Comment on lines
+51
to
+55
| // TODO replace with client span check - this is a bit different condition though, can we | ||
| // remove it? | ||
| if (!Java8BytecodeBridge.spanFromContext(parentContext).getSpanContext().isValid()) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
But this is very different condition, no? I read it that we don't want to create top level spans for rmi calls. Nothing in our instrumenters does such check.
...ent/src/main/java/io/opentelemetry/javaagent/instrumentation/rmi/context/ContextPayload.java
Show resolved
Hide resolved
.../java/io/opentelemetry/javaagent/instrumentation/rmi/server/RemoteServerInstrumentation.java
Show resolved
Hide resolved
RashmiRam
pushed a commit
to RashmiRam/opentelemetry-auto-instr-java
that referenced
this pull request
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #2713