Update jaxrs-1.0 to Instrumenter API #3797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
requested review from
anuraaga,
iNikem,
jkwatson,
laurit,
mateuszrzeszutek,
pavolloffay and
tylerbenson
as code owners
trask
commented
Aug 8, 2021
Comment on lines
-48
to
-53
| if (serverSpan == null) { | ||
| spanName = pathBasedSpanName; | ||
| } else { | ||
| spanName = SpanNames.fromMethod(target, method); | ||
| updateServerSpanName(parentContext, serverSpan, pathBasedSpanName); | ||
| } |
There was a problem hiding this comment.
Similar to #3796
I removed this special case of having a different name for the handler span name when there is no server span (now the handler span has the same name whether or not there is a server span, which is consistent with other instrumentations).
99 tasks
mateuszrzeszutek
approved these changes
Aug 9, 2021
Comment on lines
35
to
36
| String spanName() { | ||
| return SpanNames.fromMethod(target, method); |
There was a problem hiding this comment.
Why not use CodeSpanNameExtractor?
anuraaga
approved these changes
Aug 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.