Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Mongo to Instrumenter #4387

Merged
merged 5 commits into from
Oct 18, 2021
Merged

Convert Mongo to Instrumenter #4387

merged 5 commits into from
Oct 18, 2021

Conversation

iNikem
Copy link
Contributor

@iNikem iNikem commented Oct 15, 2021

No description provided.

Co-authored-by: Mateusz Rzeszutek <[email protected]>
…elemetry/instrumentation/mongo/v3_1/TracingCommandListener.java

Co-authored-by: Mateusz Rzeszutek <[email protected]>
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WDYT about maintaining a single map containing a ContextAndRequest values?

this seems like a good idea

@iNikem iNikem merged commit ae7d48c into open-telemetry:main Oct 18, 2021
@iNikem iNikem deleted the mongo branch October 18, 2021 07:22
RashmiRam pushed a commit to RashmiRam/opentelemetry-auto-instr-java that referenced this pull request May 23, 2022
* Convert Mongo to Instrumenter

* Apply suggestions from code review

Co-authored-by: Mateusz Rzeszutek <[email protected]>

* Update instrumentation/mongo/mongo-3.1/library/src/main/java/io/opentelemetry/instrumentation/mongo/v3_1/TracingCommandListener.java

Co-authored-by: Mateusz Rzeszutek <[email protected]>

* Simplify

Co-authored-by: Mateusz Rzeszutek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants