Convert Spymemcached integration to Instrumenter #4273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iNikem
requested review from
anuraaga,
jkwatson,
laurit,
mateuszrzeszutek,
pavolloffay,
trask and
tylerbenson
as code owners
99 tasks
trask
approved these changes
Oct 4, 2021
.../io/opentelemetry/javaagent/instrumentation/spymemcached/SpymemcachedAttributeExtractor.java
Outdated
Show resolved
Hide resolved
…pentelemetry/javaagent/instrumentation/spymemcached/SpymemcachedAttributeExtractor.java Co-authored-by: Trask Stalnaker <[email protected]>
anuraaga
reviewed
Oct 4, 2021
...c/main/java/io/opentelemetry/javaagent/instrumentation/spymemcached/SpymemcachedRequest.java
Outdated
Show resolved
Hide resolved
|
|
||
| protected CompletionListener( | ||
| Context parentContext, MemcachedConnection connection, String methodName) { | ||
| context = tracer().startSpan(parentContext, connection, methodName); | ||
| request = SpymemcachedRequest.create(connection, methodName); |
There was a problem hiding this comment.
Can we refactor this instrumentation to insert shouldStart() somewhere? E.g. not register the listener at all if shouldStart() returns false
There was a problem hiding this comment.
We still have to create SpymemcachedRequest for shouldStart. Plus we have CallDepth check before creating listener. I don't think we are going to have any performance gain from this 🤔
|
Oops, sorry, didn't mean to merge it -- I mistakenly clicked on the wrong PR 🙇 |
:D Well, as a punishment you now have to create a separate issue for any follow-ups left unresolved in this PR :) |
|
Good thing it was only my comment 😂 |
|
LGTM :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.