Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish opentelemetry-instrumentation-api to maven central and add marker base interface for SemanticConvention's #1388

Closed
as-polyakov opened this issue Oct 14, 2020 · 6 comments

Comments

@as-polyakov
Copy link

as-polyakov commented Oct 14, 2020

Hello folks

we intend to use TypedSpans in our instrumentations and would like to:

  1. Have "io.opentelemetry.instrumentation:opentelemetry-instrumentation-api" available on maven central
  2. Have all typed spans implement some marker interface, I would propose having a "BaseSemanticConversion" interface to be extended by all *SemanticConversion interfaces implemented by typed spans. This way I can demand in our instrumentation code that we use an instance of typed span

I can submit PR for both

@as-polyakov as-polyakov changed the title Publish opentelemetry-api to maven central and add marker base interface for SemanticConvention's Publish opentelemetry-instrumentation-api to maven central and add marker base interface for SemanticConvention's Oct 14, 2020
@trask
Copy link
Member

trask commented Oct 15, 2020

Hi @parallelstream, we aren't using the TypedSpans (yet?), and considering moving them to https://github.com/open-telemetry/opentelemetry-java/tree/master/extensions

@iNikem what do you think?

@iNikem
Copy link
Contributor

iNikem commented Oct 15, 2020

I don't think typed spans are ready for wide adoption yet. We haven't used them ourselves, so we cannot guarantee anything about them: will they live, where will they live, what's their API etc etc.

@as-polyakov
Copy link
Author

as-polyakov commented Oct 15, 2020

hey, understood. Is there anything I can do to help moving this forward? Seems natural for me that they need to be available as an implementation of semantic convention in some form. All I am trying to achieve currently - enforce semantic convention usage in our code (hence the need for marker interface) and give a "starter pack" for typical scenarios (hence the need for artifact)

@iNikem
Copy link
Contributor

iNikem commented Oct 19, 2020

Is there anything I can do to help moving this forward?

You can try to submit a PR or two where some instrumentation tracers use those typed spans. We need a proof-of-concept/example usage to iron out all rough edges.

enforce semantic convention usage in our code

Do you have any ideas how to achieve that?

@as-polyakov
Copy link
Author

You can try to submit a PR or two where some instrumentation tracers use those typed spans. We need a proof-of-concept/example usage to iron out all rough edges.

sure, I can do that

Do you have any ideas how to achieve that?

yes, hence the need for the marker interface. I was thinking of doing smith like this:

public interface HttpSemanticConvention extends BaseSemanticConvention {
...
}

public interface MySpanLogic <T extends BaseSemanticConvention> {
   public T createMySpan();
...
}

@trask
Copy link
Member

trask commented Apr 4, 2021

Closing, opentelemetry-instrumentation-api is in maven central now. TypedSpans were not being used so have been removed. Implementation of the new instrumenter API is being tracked in #2713.

@trask trask closed this as completed Apr 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants