-
Notifications
You must be signed in to change notification settings - Fork 881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish opentelemetry-instrumentation-api to maven central and add marker base interface for SemanticConvention's #1388
Comments
Hi @parallelstream, we aren't using the TypedSpans (yet?), and considering moving them to https://github.com/open-telemetry/opentelemetry-java/tree/master/extensions @iNikem what do you think? |
I don't think typed spans are ready for wide adoption yet. We haven't used them ourselves, so we cannot guarantee anything about them: will they live, where will they live, what's their API etc etc. |
hey, understood. Is there anything I can do to help moving this forward? Seems natural for me that they need to be available as an implementation of semantic convention in some form. All I am trying to achieve currently - enforce semantic convention usage in our code (hence the need for marker interface) and give a "starter pack" for typical scenarios (hence the need for artifact) |
You can try to submit a PR or two where some instrumentation tracers use those typed spans. We need a proof-of-concept/example usage to iron out all rough edges.
Do you have any ideas how to achieve that? |
sure, I can do that
yes, hence the need for the marker interface. I was thinking of doing smith like this:
|
Closing, opentelemetry-instrumentation-api is in maven central now. TypedSpans were not being used so have been removed. Implementation of the new instrumenter API is being tracked in #2713. |
Hello folks
we intend to use TypedSpans in our instrumentations and would like to:
I can submit PR for both
The text was updated successfully, but these errors were encountered: