PoC: Update Jaeger exporter to rely on the SDK for batching and NoOp performance#1803
Closed
MrAlias wants to merge 2 commits intoopen-telemetry:mainfrom
Closed
PoC: Update Jaeger exporter to rely on the SDK for batching and NoOp performance#1803MrAlias wants to merge 2 commits intoopen-telemetry:mainfrom
MrAlias wants to merge 2 commits intoopen-telemetry:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1803 +/- ##
=======================================
- Coverage 78.6% 78.4% -0.3%
=======================================
Files 134 134
Lines 7159 7137 -22
=======================================
- Hits 5633 5596 -37
- Misses 1276 1297 +21
+ Partials 250 244 -6
|
Contributor
Author
|
Going to try and break this into smaller PRs. |
This was referenced Apr 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
cloud.google.com/goby removing the use of the providedBundler.ExportSpansand rely on theBatchSpanProcessorfor batching.ExportSpansso there is no use for a flush function.InstallNewPipelineandNewExportPiepeline) to not return the now unneeded flush function.WithBufferMaxCountoption. The Jaeger exporter no longer bundles.WithBatchMaxCountoption. The Jaeger exporter no longer bundles.WithDisabledoption. Unregistered the wrapping span processor from the TracerProvider or do not set a global TracerProvider for instrumentation to use.WithSDKOptionsoption and instead pass these options directly to the convenience creation functions.Optiontype. There is not configuration needed to be set for the Jaeger exporter other than endpoint configuration (which is handled by the respective uploader configuration).Processtype. This is leftover from Remove process config for Jaeger exporter #1776.ExportSpansBenchmarks
Before
After
Related Issues
Resolve #1799