Remove options field from Jaeger exporter#1808
Merged
MrAlias merged 1 commit intoopen-telemetry:mainfrom Apr 14, 2021
Merged
Conversation
The initialization options of the exporter are not used after the Exporter is created. Stop saving them in a field.
MrAlias
requested review from
Aneurysm9,
XSAM,
dashpole,
evantorrie,
jmacd and
paivagustavo
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1808 +/- ##
=======================================
- Coverage 78.6% 78.6% -0.1%
=======================================
Files 134 134
Lines 7159 7158 -1
=======================================
- Hits 5633 5632 -1
Misses 1276 1276
Partials 250 250
|
Aneurysm9
approved these changes
Apr 13, 2021
MadVikingGod
approved these changes
Apr 14, 2021
XSAM
approved these changes
Apr 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The initialization options of the exporter are not used after the Exporter is created. Stop saving them in a field.
Part of #1803