Update Jaeger exporter convenience functions#1822
Merged
MrAlias merged 4 commits intoopen-telemetry:mainfrom Apr 20, 2021
Merged
Update Jaeger exporter convenience functions#1822MrAlias merged 4 commits intoopen-telemetry:mainfrom
MrAlias merged 4 commits intoopen-telemetry:mainfrom
Conversation
MrAlias
added
release:1.0.0-rc.1
pkg:exporter:jaeger
MrAlias
requested review from
Aneurysm9,
XSAM,
dashpole,
evantorrie,
jmacd and
paivagustavo
as code owners
Aneurysm9
approved these changes
Apr 19, 2021
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
Codecov Report
@@ Coverage Diff @@
## main #1822 +/- ##
=======================================
- Coverage 78.3% 78.1% -0.3%
=======================================
Files 135 135
Lines 7245 7245
=======================================
- Hits 5680 5665 -15
- Misses 1315 1331 +16
+ Partials 250 249 -1
|
paivagustavo
approved these changes
Apr 19, 2021
This was referenced Apr 20, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the flush function returned from the Jaeger exporter's convenience creation functions (
InstallNewPipelineandNewExportPipeline) with theTracerProviderimplementation they create. This enables the caller to shutdown and flushing of the using the relatedTracerProvidermethods.Additionally this updates the associated unit tests for these functions to test their functionality directly instead of testing functional options of the trace API's
TracerProvider.Resolves #1725
Resolves #1327
Part of #1799