Remove locking from Jaeger exporter shutdown/export#1807
Merged
MrAlias merged 5 commits intoopen-telemetry:mainfrom Apr 17, 2021
Merged
Remove locking from Jaeger exporter shutdown/export#1807MrAlias merged 5 commits intoopen-telemetry:mainfrom
MrAlias merged 5 commits intoopen-telemetry:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1807 +/- ##
=======================================
- Coverage 78.4% 78.4% -0.1%
=======================================
Files 135 135
Lines 7236 7249 +13
=======================================
+ Hits 5679 5686 +7
- Misses 1307 1313 +6
Partials 250 250
|
Aneurysm9
approved these changes
Apr 13, 2021
Contributor
Author
BenchmarkFrom #1805 : From this branch with a cherry-pick of that commit: This looks to add 3 allocs/op and not a definitive ns/op difference. This seems like a decent trade-off given the ability to hook into the context. Additionally, this (allocs and time) will be reduced much more in the ultimate destination of #1803. |
XSAM
approved these changes
Apr 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the use of a lock to guard a state variable for shutdown of the Exporter with a channel. Additionally, hook this new channel into the context used during
ExportSpansso if the exporter is shutdown in the middle of a call to this function it will cancel the context and flush.Part of #1803 and needed for #1799.