Remove process config for Jaeger exporter#1776
Merged
MrAlias merged 8 commits intoopen-telemetry:mainfrom Apr 6, 2021
Merged
Conversation
IrisTuntun
requested review from
Aneurysm9,
MrAlias,
XSAM,
dashpole,
evantorrie,
jmacd and
paivagustavo
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1776 +/- ##
=======================================
- Coverage 78.7% 78.7% -0.1%
=======================================
Files 134 134
Lines 7144 7116 -28
=======================================
- Hits 5628 5602 -26
+ Misses 1270 1268 -2
Partials 246 246
|
MrAlias
approved these changes
Apr 6, 2021
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Aneurysm9
approved these changes
Apr 6, 2021
6 tasks
MrAlias
added a commit
to MrAlias/opentelemetry-go
that referenced
this pull request
Apr 13, 2021
Use of this struct was removed in open-telemetry#1776.
MrAlias
added a commit
that referenced
this pull request
Apr 13, 2021
* Remove the abandoned Process struct in Jaeger exporter Use of this struct was removed in #1776. * Update changelog
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
Processconfiguration for Jaeger exporter. The information that could be configured in theProcessstruct should be configured in aResourceinstead. The spec-compliance-matrix will be updated in a follow-up PR.This should fix #1762