fix: performance regression from #8447 #9769
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgrinberg
force-pushed
the
ps/rr/fix__performance_regression_from__8447
branch
3 times, most recently
from
a59000a to
4efc59f
Compare
Collaborator
|
Tested, and it fixes the issue. Thanks. |
Collaborator
|
Explanation of this fix in #9761 (comment) |
Get rid of the slow dune file comparison in #9738 Signed-off-by: Rudi Grinberg <[email protected]> <!-- ps-id: 6499de7c-e597-44e0-af7f-33bf7bf235ab -->
rgrinberg
force-pushed
the
ps/rr/fix__performance_regression_from__8447
branch
from
4efc59f to
c5857d9
Compare
This was referenced Jan 30, 2024
Merged
emillon
pushed a commit
to emillon/dune
that referenced
this pull request
Feb 5, 2024
Get rid of the slow dune file comparison in ocaml#9738 Signed-off-by: Rudi Grinberg <[email protected]>
emillon
added a commit
that referenced
this pull request
Feb 5, 2024
* refactor: rename [Dune_load.conf] to [Dune_load.t] (#9766) Signed-off-by: Rudi Grinberg <[email protected]> * refactor: Make [Dune_load.t] abstract (#9767) Signed-off-by: Rudi Grinberg <[email protected]> * refactor: move [Dune_load.Dune_files.in_dir] (#9768) It doesn't need to be in the [Dune_files] submodule Signed-off-by: Rudi Grinberg <[email protected]> * fix: performance regression from #8447 (#9769) Get rid of the slow dune file comparison in #9738 Signed-off-by: Rudi Grinberg <[email protected]> --------- Signed-off-by: Rudi Grinberg <[email protected]> Co-authored-by: Rudi Grinberg <[email protected]>
emillon
added a commit
to emillon/opam-repository
that referenced
this pull request
Feb 5, 2024
CHANGES: - Fix performance regression for incremental builds (ocaml/dune#9769, fixes ocaml/dune#9738, @rgrinberg) - Fix `dune ocaml top-module` to correctly handle absolute paths. (ocaml/dune#8249, fixes ocaml/dune#7370, @Alizter) - subst: ignore broken symlinks when looking at source files (ocaml/dune#9810, fixes ocaml/dune#9593, @emillon) - subst: do not fail on 32-bit systems when large files are encountered. Just log a warning in this case. (ocaml/dune#9811, fixes ocaml/dune#9538, @emillon) - boot: sort directory entries in readdir. This makes the dune binary reproducible in terms of filesystem order. (ocaml/dune#9861, fixes ocaml/dune#9794, @emillon)
nberth
pushed a commit
to nberth/opam-repository
that referenced
this pull request
Jun 18, 2024
CHANGES: - Fix performance regression for incremental builds (ocaml/dune#9769, fixes ocaml/dune#9738, @rgrinberg) - Fix `dune ocaml top-module` to correctly handle absolute paths. (ocaml/dune#8249, fixes ocaml/dune#7370, @Alizter) - subst: ignore broken symlinks when looking at source files (ocaml/dune#9810, fixes ocaml/dune#9593, @emillon) - subst: do not fail on 32-bit systems when large files are encountered. Just log a warning in this case. (ocaml/dune#9811, fixes ocaml/dune#9538, @emillon) - boot: sort directory entries in readdir. This makes the dune binary reproducible in terms of filesystem order. (ocaml/dune#9861, fixes ocaml/dune#9794, @emillon)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get rid of the slow dune file comparison in #9738
Signed-off-by: Rudi Grinberg [email protected]