refactor: move [Dune_load.Dune_files.in_dir] #9768
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It doesn't need to be in the [Dune_files] submodule Signed-off-by: Rudi Grinberg <[email protected]> <!-- ps-id: 63511604-57a0-40fa-93f9-0259abbeaf65 -->
rgrinberg
deleted the
ps/rr/refactor__move__dune_load_dune_files_in_dir_
branch
emillon
pushed a commit
to emillon/dune
that referenced
this pull request
Feb 5, 2024
It doesn't need to be in the [Dune_files] submodule Signed-off-by: Rudi Grinberg <[email protected]>
Merged
emillon
added a commit
that referenced
this pull request
Feb 5, 2024
* refactor: rename [Dune_load.conf] to [Dune_load.t] (#9766) Signed-off-by: Rudi Grinberg <[email protected]> * refactor: Make [Dune_load.t] abstract (#9767) Signed-off-by: Rudi Grinberg <[email protected]> * refactor: move [Dune_load.Dune_files.in_dir] (#9768) It doesn't need to be in the [Dune_files] submodule Signed-off-by: Rudi Grinberg <[email protected]> * fix: performance regression from #8447 (#9769) Get rid of the slow dune file comparison in #9738 Signed-off-by: Rudi Grinberg <[email protected]> --------- Signed-off-by: Rudi Grinberg <[email protected]> Co-authored-by: Rudi Grinberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't need to be in the [Dune_files] submodule
Signed-off-by: Rudi Grinberg [email protected]