fix: correctly handle absolute paths in dune ocaml top-module #8249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alizter
force-pushed
the
ps/branch/fix__disallow_absolute_paths_in_dune_ocaml_top_module
branch
2 times, most recently
from
5811fed to
3411cef
Compare
Member
|
Instead of disallowing them, you could just strip the initial PWD and look for corresponding source file |
Collaborator
Author
|
@rgrinberg What if the prefix isn't shared? I'll have to add some logic making sure its a prefix etc. |
Member
|
If the prefix isn't shared, then the path is outside the workspace and there's very little we can do for the user. |
Collaborator
Author
|
Also I'm not sure the initial PWD is the correct thing to choose. You can imagine a project |
Member
|
Okay sure, you can use the workspace root. |
Alizter
force-pushed
the
ps/branch/fix__disallow_absolute_paths_in_dune_ocaml_top_module
branch
from
3411cef to
6cb50b8
Compare
Alizter
changed the title
Collaborator
Author
|
@rgrinberg I've implemented the prefix handling logic. There is some refactoring we should do in the future: |
Alizter
force-pushed
the
ps/branch/fix__disallow_absolute_paths_in_dune_ocaml_top_module
branch
from
6cb50b8 to
96769ee
Compare
rgrinberg
reviewed
Jul 24, 2023
bin/ocaml/top.ml
Outdated
| Path.Local.of_string module_path | ||
| else | ||
| let root = | ||
| (Common.root common).dir |> Path.of_string |
Member
There was a problem hiding this comment.
Why don't you just use Path.root here?
Signed-off-by: Ali Caglayan <[email protected]>
Member
|
I ran into this annoying issue and took the liberty to revive this PR. |
rgrinberg
force-pushed
the
ps/branch/fix__disallow_absolute_paths_in_dune_ocaml_top_module
branch
from
96769ee to
a8b63f7
Compare
emillon
pushed a commit
to emillon/dune
that referenced
this pull request
Feb 5, 2024
…8249) Signed-off-by: Ali Caglayan <[email protected]>
emillon
added a commit
that referenced
this pull request
Feb 5, 2024
…#9922) Signed-off-by: Ali Caglayan <[email protected]> Co-authored-by: Ali Caglayan <[email protected]>
emillon
added a commit
to emillon/opam-repository
that referenced
this pull request
Feb 5, 2024
CHANGES: - Fix performance regression for incremental builds (ocaml/dune#9769, fixes ocaml/dune#9738, @rgrinberg) - Fix `dune ocaml top-module` to correctly handle absolute paths. (ocaml/dune#8249, fixes ocaml/dune#7370, @Alizter) - subst: ignore broken symlinks when looking at source files (ocaml/dune#9810, fixes ocaml/dune#9593, @emillon) - subst: do not fail on 32-bit systems when large files are encountered. Just log a warning in this case. (ocaml/dune#9811, fixes ocaml/dune#9538, @emillon) - boot: sort directory entries in readdir. This makes the dune binary reproducible in terms of filesystem order. (ocaml/dune#9861, fixes ocaml/dune#9794, @emillon)
nberth
pushed a commit
to nberth/opam-repository
that referenced
this pull request
Jun 18, 2024
CHANGES: - Fix performance regression for incremental builds (ocaml/dune#9769, fixes ocaml/dune#9738, @rgrinberg) - Fix `dune ocaml top-module` to correctly handle absolute paths. (ocaml/dune#8249, fixes ocaml/dune#7370, @Alizter) - subst: ignore broken symlinks when looking at source files (ocaml/dune#9810, fixes ocaml/dune#9593, @emillon) - subst: do not fail on 32-bit systems when large files are encountered. Just log a warning in this case. (ocaml/dune#9811, fixes ocaml/dune#9538, @emillon) - boot: sort directory entries in readdir. This makes the dune binary reproducible in terms of filesystem order. (ocaml/dune#9861, fixes ocaml/dune#9794, @emillon)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.