Skip to content

Conversation

@emillon
Copy link
Contributor

@emillon emillon commented Feb 5, 2024

Fast, portable, and opinionated build system

CHANGES:

CHANGES:

- Fix performance regression for incremental builds (ocaml/dune#9769, fixes ocaml/dune#9738,
  @rgrinberg)

- Fix `dune ocaml top-module` to correctly handle absolute paths. (ocaml/dune#8249, fixes
  ocaml/dune#7370, @Alizter)

- subst: ignore broken symlinks when looking at source files (ocaml/dune#9810, fixes
  ocaml/dune#9593, @emillon)

- subst: do not fail on 32-bit systems when large files are encountered. Just
  log a warning in this case. (ocaml/dune#9811, fixes ocaml/dune#9538, @emillon)

- boot: sort directory entries in readdir. This makes the dune binary
  reproducible in terms of filesystem order. (ocaml/dune#9861, fixes ocaml/dune#9794, @emillon)
@emillon emillon mentioned this pull request Feb 5, 2024
15 tasks
@emillon
Copy link
Contributor Author

emillon commented Feb 6, 2024

No regressions compared to 3.13.0 and only the ppc64 builds are missing, so this seems good to go in my view.

@emillon
Copy link
Contributor Author

emillon commented Feb 6, 2024

(and the ppc64 build went through)

@mseri
Copy link
Member

mseri commented Feb 6, 2024

Looks good, thanks

@mseri mseri merged commit bb9f200 into ocaml:master Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

reproducible builds: filesystem readdir order Performance regression after #8447 dune subst crashes on large files (32-bit systems)

2 participants