Skip to content

chore: fix visibility issues in test suite#8454

Merged
TomAFrench merged 2 commits intomasterfrom
tf/visibility-fixes
May 12, 2025
Merged

chore: fix visibility issues in test suite#8454
TomAFrench merged 2 commits intomasterfrom
tf/visibility-fixes

Conversation

@TomAFrench
Copy link
Member

@TomAFrench TomAFrench commented May 12, 2025

Description

Problem*

Resolves

Summary*

This PR pulls out a bunch of the test suite changes from #7657 to separate them from the breaking change of making visibility issues into errors.

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

Squashed commit of the following:
9bcf104 
commit 200a2ee
Merge: 097db0d f8c6943
Author: AztecBot <tech@aztecprotocol.com>
Date:   Mon May 12 11:24:08 2025 +0000

    Merge branch 'master' into tf/enforce-visibility

commit 097db0d
Author: Tom French <15848336+TomAFrench@users.noreply.github.com>
Date:   Mon May 12 12:14:02 2025 +0100

    Update EXTERNAL_NOIR_LIBRARIES.yml

commit 0aec286
Author: Tom French <15848336+TomAFrench@users.noreply.github.com>
Date:   Mon May 12 12:13:40 2025 +0100

    Update .github/workflows/reports.yml

commit d638363
Author: AztecBot <tech@aztecprotocol.com>
Date:   Mon May 12 11:05:34 2025 +0000

    .

commit 58555e1
Author: AztecBot <tech@aztecprotocol.com>
Date:   Mon May 12 11:04:26 2025 +0000

    .

commit 2d231c3
Author: AztecBot <tech@aztecprotocol.com>
Date:   Mon May 12 10:57:01 2025 +0000

    .

commit 56d7f40
Merge: 03f53b2 6accfc6
Author: AztecBot <tech@aztecprotocol.com>
Date:   Mon May 12 10:56:54 2025 +0000

    Merge branch 'master' into tf/enforce-visibility

commit 03f53b2
Author: AztecBot <tech@aztecprotocol.com>
Date:   Tue Apr 29 11:37:30 2025 +0000

    .

commit 82c593c
Author: AztecBot <tech@aztecprotocol.com>
Date:   Tue Apr 29 11:32:45 2025 +0000

    .

commit 35804a2
Merge: 8f8e4cd 458ec57
Author: Tom French <15848336+TomAFrench@users.noreply.github.com>
Date:   Tue Apr 29 12:29:49 2025 +0100

    Merge branch 'master' into tf/enforce-visibility

commit 8f8e4cd
Author: AztecBot <tech@aztecprotocol.com>
Date:   Tue Apr 29 11:06:11 2025 +0000

    .

commit 77a8883
Merge: de89af6 96e8679
Author: AztecBot <tech@aztecprotocol.com>
Date:   Tue Apr 29 10:57:40 2025 +0000

    Merge branch 'master' into tf/enforce-visibility

commit de89af6
Author: TomAFrench <tom@tomfren.ch>
Date:   Fri Apr 18 15:09:34 2025 +0000

    bigcurve status: cooked

commit b5843a7
Author: TomAFrench <tom@tomfren.ch>
Date:   Fri Apr 18 15:00:41 2025 +0000

    .

commit 17cdad4
Author: TomAFrench <tom@tomfren.ch>
Date:   Fri Apr 18 15:00:13 2025 +0000

    .

commit 24f1519
Author: TomAFrench <tom@tomfren.ch>
Date:   Fri Apr 18 14:54:03 2025 +0000

    .

commit 28e4ae8
Author: TomAFrench <tom@tomfren.ch>
Date:   Fri Apr 18 14:53:18 2025 +0000

    .

commit 8ac84db
Merge: 44b4dcc 4acfa1c
Author: TomAFrench <tom@tomfren.ch>
Date:   Fri Apr 18 13:57:59 2025 +0000

    Merge branch 'master' into tf/enforce-visibility

commit 44b4dcc
Author: TomAFrench <tom@tomfren.ch>
Date:   Fri Apr 18 13:56:45 2025 +0000

    .

commit 4455ee9
Author: TomAFrench <tom@tomfren.ch>
Date:   Fri Apr 18 13:55:31 2025 +0000

    .

commit 0e939d1
Author: TomAFrench <tom@tomfren.ch>
Date:   Thu Apr 17 23:58:44 2025 +0000

    .

commit 48ffe36
Author: TomAFrench <tom@tomfren.ch>
Date:   Thu Apr 17 23:57:55 2025 +0000

    .

commit 0f31687
Author: TomAFrench <tom@tomfren.ch>
Date:   Thu Apr 17 23:02:54 2025 +0000

    .

commit 72f5315
Author: TomAFrench <tom@tomfren.ch>
Date:   Thu Apr 17 20:50:42 2025 +0000

    .

commit 86db477
Author: TomAFrench <tom@tomfren.ch>
Date:   Thu Apr 17 20:47:02 2025 +0000

    .

commit 3e5f696
Author: TomAFrench <tom@tomfren.ch>
Date:   Thu Apr 17 20:41:14 2025 +0000

    .

commit 273958a
Author: TomAFrench <tom@tomfren.ch>
Date:   Thu Apr 17 20:39:45 2025 +0000

    .

commit 651d998
Author: TomAFrench <tom@tomfren.ch>
Date:   Thu Apr 17 20:32:04 2025 +0000

    .

commit cf24967
Author: TomAFrench <tom@tomfren.ch>
Date:   Thu Apr 17 20:30:16 2025 +0000

    .

commit f3d06cb
Author: TomAFrench <tom@tomfren.ch>
Date:   Thu Apr 17 20:19:55 2025 +0000

    .

commit abc29df
Author: TomAFrench <tom@tomfren.ch>
Date:   Thu Apr 17 20:07:58 2025 +0000

    .

commit 8530a29
Author: TomAFrench <tom@tomfren.ch>
Date:   Thu Apr 17 19:55:06 2025 +0000

    chore: update snapshots

commit 97ecdea
Merge: 13eb87a 3f80cf2
Author: Tom French <15848336+TomAFrench@users.noreply.github.com>
Date:   Thu Apr 17 20:47:16 2025 +0100

    Merge branch 'master' into tf/enforce-visibility

commit 13eb87a
Merge: 84059a1 565c3dd
Author: Tom French <15848336+TomAFrench@users.noreply.github.com>
Date:   Mon Mar 24 15:45:45 2025 +0000

    Merge branch 'master' into tf/enforce-visibility

commit 84059a1
Merge: 71ba689 c757112
Author: Tom French <15848336+TomAFrench@users.noreply.github.com>
Date:   Mon Mar 17 12:46:11 2025 +0000

    Merge branch 'master' into tf/enforce-visibility

commit 71ba689
Author: Tom French <tom@tomfren.ch>
Date:   Tue Mar 11 12:53:44 2025 +0000

    chore!: enforce visibility warnings as errors
@github-actions
Copy link
Contributor

github-actions bot commented May 12, 2025 •
edited
Loading

Changes to Brillig bytecode sizes

Generated at commit: 0a9da1243e817d04b474479f6311dff7b4726b07, compared to commit: ef582a683eb4bf492f415d538a8695644e964db2

🧾 Summary (10% most significant diffs)

Program Brillig opcodes (+/-) %
brillig_rc_regression_6123_inliner_zero +111 ❌ +555.00%
brillig_rc_regression_6123_inliner_min +46 ❌ +24.21%
Full diff report 👇
Program Brillig opcodes (+/-) %
brillig_rc_regression_6123_inliner_zero 131 (+111) +555.00%
brillig_rc_regression_6123_inliner_min 236 (+46) +24.21%
regression_6674_3_inliner_min 837 (+121) +16.90%
regression_6674_3_inliner_max 480 (+28) +6.19%
regression_6674_3_inliner_zero 419 (+12) +2.95%

@github-actions
Copy link
Contributor

github-actions bot commented May 12, 2025 •
edited
Loading

Changes to number of Brillig opcodes executed

Generated at commit: 0a9da1243e817d04b474479f6311dff7b4726b07, compared to commit: ef582a683eb4bf492f415d538a8695644e964db2

🧾 Summary (10% most significant diffs)

Program Brillig opcodes (+/-) %
brillig_rc_regression_6123_inliner_zero +177 ❌ +983.33%
brillig_rc_regression_6123_inliner_min +140 ❌ +48.11%
Full diff report 👇
Program Brillig opcodes (+/-) %
brillig_rc_regression_6123_inliner_zero 195 (+177) +983.33%
brillig_rc_regression_6123_inliner_min 431 (+140) +48.11%
regression_6674_3_inliner_min 1,784 (+125) +7.53%
regression_6674_3_inliner_max 1,212 (+24) +2.02%
regression_6674_3_inliner_zero 1,155 (+12) +1.05%

@TomAFrench TomAFrench marked this pull request as draft May 12, 2025 16:16
@TomAFrench TomAFrench marked this pull request as ready for review May 12, 2025 16:23
@TomAFrench TomAFrench requested a review from a team May 12, 2025 16:23
vezenovm
vezenovm approved these changes May 12, 2025
View reviewed changes
Copy link
Contributor

@vezenovm vezenovm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's investigate those regressions as I expect the inliner to inline set_unchecked in brillig_rc_regression_6123

@TomAFrench TomAFrench mentioned this pull request May 12, 2025
Closed
@TomAFrench TomAFrench enabled auto-merge May 12, 2025 16:40
@TomAFrench TomAFrench added this pull request to the merge queue May 12, 2025
Merged via the queue into master with commit 5302490 May 12, 2025
115 of 116 checks passed
@TomAFrench TomAFrench deleted the tf/visibility-fixes branch May 12, 2025 17:02
@AztecBot AztecBot mentioned this pull request May 13, 2025
Merged
github-merge-queue bot pushed a commit to AztecProtocol/aztec-packages that referenced this pull request May 13, 2025
@AztecBot @TomAFrench
chore: Bump Noir reference (#14233)
5e0b14b 
Automated pull of nightly from the
[noir](https://github.com/noir-lang/noir) programming language, a
dependency of Aztec.
BEGIN_COMMIT_OVERRIDE
fix: sign extend in signed cast
(noir-lang/noir#8264)
chore(fuzz): Do not use zero length types in the main input output
(noir-lang/noir#8465)
chore: fix visibility issues in test suite
(noir-lang/noir#8454)
chore: blackbox functions for ssa intepreter
(noir-lang/noir#8375)
feat: improve bitshift codegen
(noir-lang/noir#8442)
fix(ssa): Mark mutually recursive simple functions
(noir-lang/noir#8447)
fix: Fix nested trait dispatch with associated types
(noir-lang/noir#8440)
chore: carry visibilities in monomorphized AST
(noir-lang/noir#8439)
chore(tests): Add regression for now passing test
(noir-lang/noir#8441)
chore: use human-readable bytecode in snapshots
(noir-lang/noir#8164)
chore: bump external pinned commits
(noir-lang/noir#8445)
END_COMMIT_OVERRIDE

---------

Co-authored-by: AztecBot <tech@aztecprotocol.com>
Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vezenovm vezenovm vezenovm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TomAFrench @vezenovm