chore: fix visibility issues in test suite

compiler/wasm/test/fixtures/deps/lib-c/src/lib.nr

@@ -1 +1 @@
-mod module;
+pub mod module;

compiler/wasm/test/fixtures/deps/lib-c/src/module.nr

@@ -1 +1 @@
-mod foo;
+pub mod foo;

test_programs/compile_failure/dep_submodule_overlap/src/lib.nr

@@ -1,3 +1,3 @@
-struct MyStruct {
+pub(crate) struct MyStruct {
     inner: Field
 }

test_programs/compile_failure/dep_submodule_overlap/stderr.txt

@@ -1,15 +1,8 @@
-warning: MyStruct is private and not visible from the current module
-  ┌─ src/main.nr:4:17
-  │
-4 │ use crate::lib::MyStruct;
-  │                 -------- MyStruct is private
-  │
-
 warning: struct `MyStruct` is never constructed
-  ┌─ src/lib.nr:1:8
+  ┌─ src/lib.nr:1:19
   │
-1 │ struct MyStruct {
-  │        -------- struct is never constructed
+1 │ pub(crate) struct MyStruct {
+  │                   -------- struct is never constructed
   │
 
 error: Duplicate definitions of import with name lib found
@@ -39,4 +32,4 @@ error: Could not resolve 'is_struct_zero' in path
   │                 --------------
   │
 
-Aborting due to 3 previous errors
+Aborting due to 3 previous errors

test_programs/compile_failure/dup_trait_implementation_4/src/module1.nr

@@ -1,2 +1,2 @@
-trait MyTrait {
+pub(crate) trait MyTrait {
 }

test_programs/compile_failure/dup_trait_implementation_4/src/module2.nr

@@ -1,2 +1,2 @@
-struct MyStruct {
+pub(crate) struct MyStruct {
 }

test_programs/compile_failure/dup_trait_implementation_4/stderr.txt

@@ -1,50 +1,8 @@
-warning: MyTrait is private and not visible from the current module
-  ┌─ src/module3.nr:1:21
-  │
-1 │ use crate::module1::MyTrait;
-  │                     ------- MyTrait is private
-  │
-
-warning: MyStruct is private and not visible from the current module
-  ┌─ src/module3.nr:2:21
-  │
-2 │ use crate::module2::MyStruct;
-  │                     -------- MyStruct is private
-  │
-
-warning: MyTrait is private and not visible from the current module
-  ┌─ src/module3.nr:6:22
-  │
-6 │ impl crate::module1::MyTrait for crate::module2::MyStruct { }
-  │                      ------- MyTrait is private
-  │
-
-warning: MyStruct is private and not visible from the current module
-  ┌─ src/module3.nr:6:50
-  │
-6 │ impl crate::module1::MyTrait for crate::module2::MyStruct { }
-  │                                                  -------- MyStruct is private
-  │
-
-warning: MyStruct is private and not visible from the current module
-  ┌─ src/module3.nr:6:50
-  │
-6 │ impl crate::module1::MyTrait for crate::module2::MyStruct { }
-  │                                                  -------- MyStruct is private
-  │
-
-warning: MyStruct is private and not visible from the current module
-  ┌─ src/module3.nr:6:50
-  │
-6 │ impl crate::module1::MyTrait for crate::module2::MyStruct { }
-  │                                                  -------- MyStruct is private
-  │
-
 warning: struct `MyStruct` is never constructed
-  ┌─ src/module2.nr:1:8
+  ┌─ src/module2.nr:1:19
   │
-1 │ struct MyStruct {
-  │        -------- struct is never constructed
+1 │ pub(crate) struct MyStruct {
+  │                   -------- struct is never constructed
   │
 
 error: Impl for type `MyStruct` overlaps with existing impl
@@ -56,4 +14,4 @@ error: Impl for type `MyStruct` overlaps with existing impl
   │                                  ------------------------ Overlapping impl
   │
 
-Aborting due to 1 previous error
+Aborting due to 1 previous error

test_programs/compile_failure/dup_trait_implementation_5/src/module1.nr

@@ -1,2 +1,2 @@
-trait MyTrait {
+pub(crate) trait MyTrait {
 }

test_programs/compile_failure/dup_trait_implementation_5/src/module2.nr

@@ -1,2 +1,2 @@
-struct MyStruct {
+pub(crate) struct MyStruct {
 }

test_programs/compile_failure/dup_trait_implementation_5/stderr.txt

@@ -1,50 +1,8 @@
-warning: MyTrait is private and not visible from the current module
-  ┌─ src/module3.nr:1:21
-  │
-1 │ use crate::module1::MyTrait;
-  │                     ------- MyTrait is private
-  │
-
-warning: MyStruct is private and not visible from the current module
-  ┌─ src/module3.nr:2:21
-  │
-2 │ use crate::module2::MyStruct;
-  │                     -------- MyStruct is private
-  │
-
-warning: MyTrait is private and not visible from the current module
-  ┌─ src/module4.nr:3:22
-  │
-3 │ impl crate::module1::MyTrait for crate::module2::MyStruct { }
-  │                      ------- MyTrait is private
-  │
-
-warning: MyStruct is private and not visible from the current module
-  ┌─ src/module4.nr:3:50
-  │
-3 │ impl crate::module1::MyTrait for crate::module2::MyStruct { }
-  │                                                  -------- MyStruct is private
-  │
-
-warning: MyStruct is private and not visible from the current module
-  ┌─ src/module4.nr:3:50
-  │
-3 │ impl crate::module1::MyTrait for crate::module2::MyStruct { }
-  │                                                  -------- MyStruct is private
-  │
-
-warning: MyStruct is private and not visible from the current module
-  ┌─ src/module4.nr:3:50
-  │
-3 │ impl crate::module1::MyTrait for crate::module2::MyStruct { }
-  │                                                  -------- MyStruct is private
-  │
-
 warning: struct `MyStruct` is never constructed
-  ┌─ src/module2.nr:1:8
+  ┌─ src/module2.nr:1:19
   │
-1 │ struct MyStruct {
-  │        -------- struct is never constructed
+1 │ pub(crate) struct MyStruct {
+  │                   -------- struct is never constructed
   │
 
 error: Impl for type `MyStruct` overlaps with existing impl
@@ -59,4 +17,4 @@ error: Impl for type `MyStruct` overlaps with existing impl
   │      ------- Previous impl defined here
   │
 
-Aborting due to 1 previous error
+Aborting due to 1 previous error

test_programs/compile_failure/orphaned_trait_impl/crate1/src/lib.nr

@@ -1,2 +1,2 @@
-trait MyTrait {
+pub(crate) trait MyTrait {
 }

test_programs/compile_failure/orphaned_trait_impl/stderr.txt

@@ -33,4 +33,4 @@ error: Orphaned trait implementation
   │                          ---------------- Either the type or the trait must be from the same crate as the trait implementation
   │
 
-Aborting due to 1 previous error
+Aborting due to 1 previous error

test_programs/compile_success_no_bug/databus_mapping_regression/src/main.nr

@@ -26,7 +26,7 @@ where
         }
     }
 
-    BoundedVec { storage: array, len }
+    BoundedVec::from_parts_unchecked(array, len)
 }
 
 global TX_SIZE: u32 = 5;

test_programs/execution_success/bench_2_to_17/Nargo.toml

@@ -4,4 +4,5 @@ type = "bin"
 authors = [""]
 compiler_version = ">=0.33.0"
 
-[dependencies]
+[dependencies]
+poseidon = { git = "https://github.com/noir-lang/poseidon", tag = "v0.1.0" }

test_programs/execution_success/bench_2_to_17/src/main.nr

@@ -1,8 +1,6 @@
-use std::hash::poseidon2;
-
 global len: u32 = 2450 * 2;
 fn main(x: Field) {
     let ped_input = [x; len];
-    let mut val = poseidon2::Poseidon2::hash(ped_input, len);
+    let mut val = poseidon::poseidon2::Poseidon2::hash(ped_input, len);
     assert(val != 0);
 }

test_programs/execution_success/brillig_rc_regression_6123/src/main.nr

@@ -19,18 +19,18 @@ impl Builder {
 }
 
 fn swap_items<T, let N: u32>(vec: &mut BoundedVec<T, N>, from_index: u32, to_index: u32) {
-    let tmp = vec.storage[from_index];
-    vec.storage[from_index] = vec.storage[to_index];
-    vec.storage[to_index] = tmp;
+    let tmp = vec.get_unchecked(from_index);
+    vec.set_unchecked(from_index, vec.get_unchecked(to_index));
+    vec.set_unchecked(to_index, tmp);
 }
 
 unconstrained fn main() {
     let mut builder = Builder { note_hashes: BoundedVec::new(), nullifiers: BoundedVec::new() };
 
     builder.append_note_hashes_with_logs(2);
-    builder.nullifiers.storage[1] = 27;
+    builder.nullifiers.set_unchecked(1, 27);
     // Get ordered items before shuffling.
-    let note_hashes = builder.note_hashes.storage;
+    let note_hashes = builder.note_hashes.storage();
     let original_first_note_hash = note_hashes[0];
     // Shuffle.
     swap_items(&mut builder.note_hashes, 1, 0);

test_programs/execution_success/fold_numeric_generic_poseidon/Nargo.toml

@@ -4,4 +4,5 @@ type = "bin"
 authors = [""]
 compiler_version = ">=0.27.0"
 
-[dependencies]
+[dependencies]
+poseidon = { git = "https://github.com/noir-lang/poseidon", tag = "v0.1.0" }

test_programs/execution_success/fold_numeric_generic_poseidon/src/main.nr

@@ -1,11 +1,9 @@
-use std::hash::poseidon2::Poseidon2;
-
 global NUM_HASHES: u32 = 2;
 global HASH_LENGTH: u32 = 10;
 
 #[fold]
 pub fn poseidon_hash<let N: u32>(inputs: [Field; N]) -> Field {
-    Poseidon2::hash(inputs, inputs.len())
+    poseidon::poseidon2::Poseidon2::hash(inputs, inputs.len())
 }
 
 fn main(

test_programs/execution_success/global_consts/src/foo.nr

@@ -1,8 +1,7 @@
-mod bar;
+pub(crate) mod bar;
 
-global N: u32 = 5;
-global MAGIC_NUMBER: u32 = 3;
-global TYPE_INFERRED: u32 = 42;
+pub(crate) global MAGIC_NUMBER: u32 = 3;
+pub(crate) global TYPE_INFERRED: u32 = 42;
 
 pub fn from_foo(x: [Field; bar::N]) {
     for i in 0..bar::N {

test_programs/execution_success/global_consts/src/foo/bar.nr

@@ -1,4 +1,4 @@
-global N: u32 = 5;
+pub(crate) global N: u32 = 5;
 
 pub fn from_bar(x: Field) -> Field {
     x * N as Field

test_programs/execution_success/global_consts/src/main.nr

@@ -94,12 +94,7 @@ fn arrays_neq(a: [Field; M], b: [Field; M]) {
 }
 
 mod my_submodule {
-    global N: u32 = 10;
-    global L: Field = 50;
-
-    fn my_bool_or(x: u1, y: u1) {
-        assert(x | y == 1);
-    }
+    pub(crate) global N: u32 = 10;
 
     pub fn my_helper() -> Field {
         let N: u32 = 15; // Like in Rust, local variables override globals

test_programs/execution_success/hashmap/Nargo.toml

@@ -3,4 +3,5 @@ name = "hashmap"
 type = "bin"
 authors = [""]
 
-[dependencies]
+[dependencies]
+poseidon = { git = "https://github.com/noir-lang/poseidon", tag = "v0.1.0" }

test_programs/execution_success/hashmap/src/main.nr

@@ -1,8 +1,8 @@
 mod utils;
 
+use poseidon::poseidon2::Poseidon2Hasher;
 use std::collections::map::HashMap;
 use std::hash::BuildHasherDefault;
-use std::hash::poseidon2::Poseidon2Hasher;
 
 use utils::cut;
 

test_programs/execution_success/modules_more/src/foo.nr

@@ -1,4 +1,4 @@
-mod bar;
+pub(crate) mod bar;
 
 fn hello(x: Field) -> Field {
     x

test_programs/execution_success/no_predicates_numeric_generic_poseidon/Nargo.toml

@@ -4,4 +4,5 @@ type = "bin"
 authors = [""]
 compiler_version = ">=0.28.0"
 
-[dependencies]
+[dependencies]
+poseidon = { git = "https://github.com/noir-lang/poseidon", tag = "v0.1.0" }

test_programs/execution_success/no_predicates_numeric_generic_poseidon/src/main.nr

@@ -1,4 +1,4 @@
-use std::hash::poseidon2::Poseidon2;
+use poseidon::poseidon2::Poseidon2;
 
 global NUM_HASHES: u32 = 2;
 global HASH_LENGTH: u32 = 10;

test_programs/execution_success/regression_3889/src/main.nr

@@ -1,20 +1,20 @@
 mod Foo {
-    struct NewType {
-        a: Field,
+    pub(crate) struct NewType {
+        pub(crate) a: Field,
     }
 }
 
 mod Bar {
-    use crate::Foo::NewType;
-    use crate::Foo::NewType as BarStruct;
+    pub(crate) use crate::Foo::NewType;
+    pub(crate) use crate::Foo::NewType as BarStruct;
 }
 
 mod Baz {
-    struct Works {
-        a: Field,
+    pub(crate) struct Works {
+        pub(crate) a: Field,
     }
-    use crate::Bar::BarStruct;
-    use crate::Bar::NewType;
+    pub(crate) use crate::Bar::BarStruct;
+    pub(crate) use crate::Bar::NewType;
 }
 
 fn main(works: Baz::Works, fails: Baz::BarStruct, also_fails: Bar::NewType) -> pub Field {

test_programs/execution_success/regression_5615/Nargo.toml

@@ -5,3 +5,4 @@ authors = [""]
 compiler_version = ">=0.32.0"
 
 [dependencies]
+poseidon = { git = "https://github.com/noir-lang/poseidon", tag = "v0.1.0" }

test_programs/execution_success/regression_5615/src/main.nr

@@ -1,6 +1,6 @@
+use poseidon::poseidon2::Poseidon2Hasher;
 use std::collections::umap::UHashMap;
 use std::hash::BuildHasherDefault;
-use std::hash::poseidon2::Poseidon2Hasher;
 
 unconstrained fn main() {
     comptime {