chore: blackbox functions for ssa intepreter#8375
Conversation
jfecher
left a comment
jfecher
left a comment
There was a problem hiding this comment.
Looks good though the SSA interpreter shouldn't panic even on bad input - it should return a InternalError instead. There's a lot of comments but most are just flagging places to return a InternalError instead of calling unwrap/expect.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Compilation Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 656fa26 | Previous: 3a01a27 | Ratio |
|---|---|---|---|
private-kernel-reset |
8.606 s |
6.382 s |
1.35 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
jfecher
left a comment
jfecher
left a comment
There was a problem hiding this comment.
Looks good, just missing DerivePedersenGenerators now
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Execution Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 3e0461d | Previous: 6accfc6 | Ratio |
|---|---|---|---|
rollup-merge |
0.004 s |
0.003 s |
1.33 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
Automated pull of nightly from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE fix: sign extend in signed cast (noir-lang/noir#8264) chore(fuzz): Do not use zero length types in the main input output (noir-lang/noir#8465) chore: fix visibility issues in test suite (noir-lang/noir#8454) chore: blackbox functions for ssa intepreter (noir-lang/noir#8375) feat: improve bitshift codegen (noir-lang/noir#8442) fix(ssa): Mark mutually recursive simple functions (noir-lang/noir#8447) fix: Fix nested trait dispatch with associated types (noir-lang/noir#8440) chore: carry visibilities in monomorphized AST (noir-lang/noir#8439) chore(tests): Add regression for now passing test (noir-lang/noir#8441) chore: use human-readable bytecode in snapshots (noir-lang/noir#8164) chore: bump external pinned commits (noir-lang/noir#8445) END_COMMIT_OVERRIDE --------- Co-authored-by: AztecBot <tech@aztecprotocol.com> Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
3 participants
Description
Problem*
Resolves #8283
Summary*
Implementait the remaining intrinsic for the ssa interpreter
Additional Context
A few intrinsics have been left out because they should never appear at this point.
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.