chore(tests): Add regression for now passing test#8441
Conversation
|
I think if we're testing compiler behaviour then we should have this in Looks like we're using a stdlib test to test the compiler is correct rather than testing the actual stdlib implementation of that logic. |
|
ehhhh, on second look this is a sensible testcase for a sorting algo. I was just thrown by the test being duplicated for local and global inputs. I'd probably simplify to just have one of those. |
I switched to one test in the stdlib. Did you still want this under |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Execution Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: b72929a | Previous: 6accfc6 | Ratio |
|---|---|---|---|
rollup-merge |
0.004 s |
0.003 s |
1.33 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Execution Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 0cf4198 | Previous: 6accfc6 | Ratio |
|---|---|---|---|
rollup-merge |
0.004 s |
0.003 s |
1.33 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
|
Switched to testing under |
Automated pull of nightly from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE fix: sign extend in signed cast (noir-lang/noir#8264) chore(fuzz): Do not use zero length types in the main input output (noir-lang/noir#8465) chore: fix visibility issues in test suite (noir-lang/noir#8454) chore: blackbox functions for ssa intepreter (noir-lang/noir#8375) feat: improve bitshift codegen (noir-lang/noir#8442) fix(ssa): Mark mutually recursive simple functions (noir-lang/noir#8447) fix: Fix nested trait dispatch with associated types (noir-lang/noir#8440) chore: carry visibilities in monomorphized AST (noir-lang/noir#8439) chore(tests): Add regression for now passing test (noir-lang/noir#8441) chore: use human-readable bytecode in snapshots (noir-lang/noir#8164) chore: bump external pinned commits (noir-lang/noir#8445) END_COMMIT_OVERRIDE --------- Co-authored-by: AztecBot <tech@aztecprotocol.com> Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
2 participants
Description
Problem*
Resolves #8018
Summary*
While looking at a separate inlining panic, I was going through the other inlining bugs to see where there may be similarities. I noticed that this regression does seem to be failing on master so I have added a new test under
noir_test_success.Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.