chore!: enforce visibility warnings as errors#7657
Merged
TomAFrench merged 62 commits intomasterfrom Jul 22, 2025
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 564994e | Previous: 366149f | Ratio |
|---|---|---|---|
test_report_zkpassport_noir_rsa_ |
1 s |
0 s |
+∞ |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
asterite
reviewed
Jul 17, 2025
asterite
reviewed
Jul 17, 2025
asterite
reviewed
Jul 17, 2025
asterite
reviewed
Jul 17, 2025
Co-authored-by: Ary Borenszweig <asterite@gmail.com>
TomAFrench
commented
Jul 18, 2025
asterite
approved these changes
Jul 18, 2025
github-merge-queue bot
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Jul 30, 2025
Syncs Noir up to commit `b28776c8a68dbc319e2ffcee350b8e2a71b20096` and includes this commits: chore: Document type coercions (noir-lang/noir#9292) feat: add better handling for follow-on optimizations in `simplify_cfg` (noir-lang/noir#9276) chore: Update noir-lang/sparse_array failures status (noir-lang/noir#9289) chore: Mark `sparse_array` and `noir_json_parser` as non-critical (noir-lang/noir#9282) fix: Use `u32` in `RepeatedValue` example in generics docs (noir-lang/noir#9273) chore!: enforce visibility warnings as errors (noir-lang/noir#7657) At commit `60222bb380da2c6840adb91317bee2ca4db30d2a` the Noir sync beyond `b28776c8a68dbc319e2ffcee350b8e2a71b20096` --------- Co-authored-by: AztecBot <tech@aztecprotocol.com> Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com> Co-authored-by: Jan Beneš <janbenes1234@gmail.com>
github-merge-queue bot
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Jul 30, 2025
Syncs Noir up to commit `b28776c8a68dbc319e2ffcee350b8e2a71b20096` and includes this commits: chore: Document type coercions (noir-lang/noir#9292) feat: add better handling for follow-on optimizations in `simplify_cfg` (noir-lang/noir#9276) chore: Update noir-lang/sparse_array failures status (noir-lang/noir#9289) chore: Mark `sparse_array` and `noir_json_parser` as non-critical (noir-lang/noir#9282) fix: Use `u32` in `RepeatedValue` example in generics docs (noir-lang/noir#9273) chore!: enforce visibility warnings as errors (noir-lang/noir#7657) Commit `60222bb380da2c6840adb91317bee2ca4db30d2a` causes failing tests so could not sync Noir beyond `b28776c8a68dbc319e2ffcee350b8e2a71b20096` (relevant slack discussion [here](https://aztecprotocol.slack.com/archives/C0183F0V42V/p1753811323086949)). --------- Co-authored-by: AztecBot <tech@aztecprotocol.com> Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com> Co-authored-by: Jan Beneš <janbenes1234@gmail.com>
github-merge-queue bot
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Jul 30, 2025
Syncs Noir up to commit `b28776c8a68dbc319e2ffcee350b8e2a71b20096` and includes this commits: chore: Document type coercions (noir-lang/noir#9292) feat: add better handling for follow-on optimizations in `simplify_cfg` (noir-lang/noir#9276) chore: Update noir-lang/sparse_array failures status (noir-lang/noir#9289) chore: Mark `sparse_array` and `noir_json_parser` as non-critical (noir-lang/noir#9282) fix: Use `u32` in `RepeatedValue` example in generics docs (noir-lang/noir#9273) chore!: enforce visibility warnings as errors (noir-lang/noir#7657) Commit `60222bb380da2c6840adb91317bee2ca4db30d2a` causes failing tests so could not sync Noir beyond `b28776c8a68dbc319e2ffcee350b8e2a71b20096` (relevant slack discussion [here](https://aztecprotocol.slack.com/archives/C0183F0V42V/p1753811323086949)). --------- Co-authored-by: AztecBot <tech@aztecprotocol.com> Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com> Co-authored-by: Jan Beneš <janbenes1234@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves #6934
Summary*
Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.