chore: add a workflow that tracks acvm version for integration tests#2700
Merged
TomAFrench merged 47 commits intomasterfrom Sep 16, 2023
Merged
chore: add a workflow that tracks acvm version for integration tests#2700TomAFrench merged 47 commits intomasterfrom
TomAFrench merged 47 commits intomasterfrom
Conversation
added 17 commits
September 14, 2023 17:37
Member
|
Wouldn't it be easier to just have a check that |
…g/noir into jb-track-acvm-integration-tests
…g/noir into jb-track-acvm-integration-tests
added 2 commits
September 14, 2023 22:59
TomAFrench
reviewed
Sep 14, 2023
Member
TomAFrench
left a comment
TomAFrench
left a comment
There was a problem hiding this comment.
Looks good, couple of nits
Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
…g/noir into jb-track-acvm-integration-tests
TomAFrench
reviewed
Sep 15, 2023
kobyhallx
previously approved these changes
Sep 15, 2023
kevaundray
reviewed
Sep 15, 2023
* master: chore(ci): Treat clippy warnings as errors in CI (#2684) chore(ci): Cache yarn and playwright dependencies in CI (#2697) chore: Add noir-wasm publishing as a workflow (#2721) fix: failing js tests (#2722) chore: Add deprecation message for default type in for loop (#2689) chore!: Change `noir-lang/noir-source-resolver` to `noir-lang/source-resolver` (#2718) chore: clippy fixes (#2719) chore: Integrate noir.js into workspace and CI release workflow (#2705) feat: Add initial version of noir.js (#2681) chore: switch `release-source-resolver.yml` to use yarn (#2704) chore: move stranded test to correct directory (#2701) chore(ci): deny wildcard dependencies (#2702) chore: fix `noirc_abi_wasm` publish for release-please (#2699)
|
Removed dependencies detected. Learn more about Socket for GitHub ↗︎ 🚮 Removed packages: @aztec/bb.js@0.5.1 |
TomAFrench
approved these changes
Sep 15, 2023
TomAFrench
added a commit
that referenced
this pull request
Sep 20, 2023
* master: feat(traits): Type checking for Trait impl method signatures (#2652) chore: split 9_conditional test case and remove 8_integration (#2751) chore(github): Add "Idea Action Plan" Issue template (#2736) feat(aztec-noir): abstract storage (#2750) feat: signed arithmetic (#2748) chore: encapsulate abstraction leaks from `bb` into new crate (#2747) feat: Variable liveness analysis for brillig (#2715) chore: noirjs integration testing (#2744) chore: Add rust-toolchain file & adapt nix for changes (#2686) chore: wrap backend info response in a struct instead of boxed closure (#2737) fix: check for literal overflows in expressions (#2742) fix: nightly js test (#2740) fix: keep the correct type for bitshift (#2739) chore: Make new daily nightly releases be pre-releases and non latest (#2735) chore: disabling display location section (#2118) chore: add a workflow that tracks acvm version for integration tests (#2700) feat: Save nightly build in github releases with date tags (#2416) chore: Add unified linting setup for JS code and enforce in CI (#2728)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a workflow that checks that the version of the acvm of the integration test matches the acvm version specified in the Cargo.lock
Problem*
Resolves #2706
Summary*
Documentation
This PR requires documentation updates when merged.
Additional Context
PR Checklist*
cargo fmton default settings.