Skip to content

fix: failing js tests#2722

Merged
kobyhallx merged 4 commits intomasterfrom
kh-fix-integration
Sep 15, 2023
Merged

fix: failing js tests#2722
kobyhallx merged 4 commits intomasterfrom
kh-fix-integration

Conversation

@kobyhallx
Copy link
Contributor

@kobyhallx kobyhallx commented Sep 15, 2023

Description

Resolves nightly test-integration failed#2708

Problem*

Resolves

Summary*

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@TomAFrench
Copy link
Member

I've rolled this change into #2714

@socket-security
Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@noir-lang/acvm_js 0.26.1 None +0 5.84 MB noir-lang

@kobyhallx
Copy link
Contributor Author

@kobyhallx kobyhallx marked this pull request as ready for review September 15, 2023 16:17
@kobyhallx kobyhallx enabled auto-merge September 15, 2023 16:18
@kobyhallx kobyhallx added this pull request to the merge queue Sep 15, 2023
Merged via the queue into master with commit 398b6d7 Sep 15, 2023
@kobyhallx kobyhallx deleted the kh-fix-integration branch September 15, 2023 16:33
TomAFrench added a commit that referenced this pull request Sep 15, 2023
* master:
  fix: failing js tests (#2722)
  chore: Add deprecation message for default type in for loop (#2689)
TomAFrench added a commit that referenced this pull request Sep 15, 2023
* master:
  chore(ci): Treat clippy warnings as errors in CI (#2684)
  chore(ci): Cache yarn and playwright dependencies in CI (#2697)
  chore: Add noir-wasm publishing as a workflow (#2721)
  fix: failing js tests (#2722)
  chore: Add deprecation message for default type in for loop (#2689)
  chore!: Change `noir-lang/noir-source-resolver` to `noir-lang/source-resolver` (#2718)
  chore: clippy fixes (#2719)
  chore: Integrate noir.js into workspace and CI release workflow (#2705)
  feat: Add initial version of noir.js (#2681)
  chore: switch `release-source-resolver.yml` to use yarn (#2704)
  chore: move stranded test to correct directory (#2701)
  chore(ci): deny wildcard dependencies (#2702)
  chore: fix `noirc_abi_wasm` publish for release-please (#2699)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nightly test-integration failed

2 participants