Skip to content

chore: Add deprecation message for default type in for loop#2689

Merged
kevaundray merged 4 commits intomasterfrom
kw/default-type-for-loop
Sep 15, 2023
Merged

chore: Add deprecation message for default type in for loop#2689
kevaundray merged 4 commits intomasterfrom
kw/default-type-for-loop

Conversation

@kevaundray
Copy link
Contributor

@kevaundray kevaundray commented Sep 13, 2023

Description

Resolves #1979

Problem*

Resolves

Summary*

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@kevaundray kevaundray marked this pull request as ready for review September 14, 2023 10:28
@kevaundray kevaundray added this pull request to the merge queue Sep 15, 2023
Merged via the queue into master with commit 9b77c1a Sep 15, 2023
@kevaundray kevaundray deleted the kw/default-type-for-loop branch September 15, 2023 15:55
TomAFrench added a commit that referenced this pull request Sep 15, 2023
* master:
  chore: Add deprecation message for default type in for loop (#2689)
  chore!: Change `noir-lang/noir-source-resolver` to `noir-lang/source-resolver` (#2718)
  chore: clippy fixes (#2719)
  chore: Integrate noir.js into workspace and CI release workflow (#2705)
  feat: Add initial version of noir.js (#2681)
  chore: switch `release-source-resolver.yml` to use yarn (#2704)
  chore: move stranded test to correct directory (#2701)
  chore(ci): deny wildcard dependencies (#2702)
  chore: fix `noirc_abi_wasm` publish for release-please (#2699)
  chore: introduce workspace for js packages (#2677)
  feat: Allow methods defined in a contract to be non-entry points (#2687)
  chore: revert some unwanted small changes from PR2180 (#2685)
  feat(lsp): Add nargo capabilities for test metadata (#2532)
  chore(ci): Add `cargo deny` workflow (#2682)
TomAFrench added a commit that referenced this pull request Sep 15, 2023
* master:
  fix: failing js tests (#2722)
  chore: Add deprecation message for default type in for loop (#2689)
TomAFrench added a commit that referenced this pull request Sep 15, 2023
* master:
  chore(ci): Treat clippy warnings as errors in CI (#2684)
  chore(ci): Cache yarn and playwright dependencies in CI (#2697)
  chore: Add noir-wasm publishing as a workflow (#2721)
  fix: failing js tests (#2722)
  chore: Add deprecation message for default type in for loop (#2689)
  chore!: Change `noir-lang/noir-source-resolver` to `noir-lang/source-resolver` (#2718)
  chore: clippy fixes (#2719)
  chore: Integrate noir.js into workspace and CI release workflow (#2705)
  feat: Add initial version of noir.js (#2681)
  chore: switch `release-source-resolver.yml` to use yarn (#2704)
  chore: move stranded test to correct directory (#2701)
  chore(ci): deny wildcard dependencies (#2702)
  chore: fix `noirc_abi_wasm` publish for release-please (#2699)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The compiler issues field comparisons for loops at the SSA level

2 participants