feat: Add initial version of noir.js#2681
Merged
TomAFrench merged 15 commits intomasterfrom Sep 14, 2023
Merged
Conversation
added 3 commits
September 13, 2023 16:11
|
Updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
kevaundray
reviewed
Sep 13, 2023
TomAFrench
reviewed
Sep 14, 2023
TomAFrench
reviewed
Sep 14, 2023
Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
5 tasks
kevaundray
reviewed
Sep 14, 2023
Member
|
On second thoughts, might it be safer to require the version bump to have been done already manually? This makes running the release workflow idempotent. |
Member
|
Not a blocker. |
Contributor
yeah I don't mind doing that |
Member
|
Actually, let's merge this and then we can address both workflows together. |
Contributor
|
Oh sorry already pushed it |
TomAFrench
approved these changes
Sep 14, 2023
TomAFrench
added a commit
that referenced
this pull request
Sep 15, 2023
* tf/split-build-and-test: chore: remove reference to `result` directory chore!: Change `noir-lang/noir-source-resolver` to `noir-lang/source-resolver` (#2718) chore: clippy fixes (#2719) chore: fix version querying chore: nits chore(ci): fix playwright caching chore: pass full `package.json` into build artifact chore: clean up straggler `packageManager` chore: remove `packageManager" fields from workspace packages chore: refresh lockfile Update .github/workflows/abi_wasm.yml chore: split build and tests jobs in `abi_wasm.yml` chore: Integrate noir.js into workspace and CI release workflow (#2705) feat: Add initial version of noir.js (#2681) chore: switch `release-source-resolver.yml` to use yarn (#2704) chore: move stranded test to correct directory (#2701) chore(ci): deny wildcard dependencies (#2702) chore: fix `noirc_abi_wasm` publish for release-please (#2699)
TomAFrench
added a commit
that referenced
this pull request
Sep 15, 2023
* master: chore: Add deprecation message for default type in for loop (#2689) chore!: Change `noir-lang/noir-source-resolver` to `noir-lang/source-resolver` (#2718) chore: clippy fixes (#2719) chore: Integrate noir.js into workspace and CI release workflow (#2705) feat: Add initial version of noir.js (#2681) chore: switch `release-source-resolver.yml` to use yarn (#2704) chore: move stranded test to correct directory (#2701) chore(ci): deny wildcard dependencies (#2702) chore: fix `noirc_abi_wasm` publish for release-please (#2699) chore: introduce workspace for js packages (#2677) feat: Allow methods defined in a contract to be non-entry points (#2687) chore: revert some unwanted small changes from PR2180 (#2685) feat(lsp): Add nargo capabilities for test metadata (#2532) chore(ci): Add `cargo deny` workflow (#2682)
TomAFrench
added a commit
that referenced
this pull request
Sep 15, 2023
* master: chore(ci): Treat clippy warnings as errors in CI (#2684) chore(ci): Cache yarn and playwright dependencies in CI (#2697) chore: Add noir-wasm publishing as a workflow (#2721) fix: failing js tests (#2722) chore: Add deprecation message for default type in for loop (#2689) chore!: Change `noir-lang/noir-source-resolver` to `noir-lang/source-resolver` (#2718) chore: clippy fixes (#2719) chore: Integrate noir.js into workspace and CI release workflow (#2705) feat: Add initial version of noir.js (#2681) chore: switch `release-source-resolver.yml` to use yarn (#2704) chore: move stranded test to correct directory (#2701) chore(ci): deny wildcard dependencies (#2702) chore: fix `noirc_abi_wasm` publish for release-please (#2699)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A simple package that exports
acvm_jsandnoirc_abiProblem*
Resolves noir-lang/Planning#31
Resolves noir-lang/Planning#32
Summary*
Creates a package that exports acvm_js and noirc_abi
Documentation
This PR requires documentation updates when merged.
Additional Context
PR Checklist*
cargo fmton default settings.