feat(traits): Type checking for Trait impl method signatures #2652
Merged
jfecher merged 12 commits intonoir-lang:masterfrom Sep 19, 2023
Merged
feat(traits): Type checking for Trait impl method signatures #2652jfecher merged 12 commits intonoir-lang:masterfrom
jfecher merged 12 commits intonoir-lang:masterfrom
Conversation
alexvitkov
changed the title
alexvitkov
force-pushed
the
traits-impl-methods-typecheck
branch
from
d270dde to
5f4539a
Compare
This was referenced Sep 15, 2023
alexvitkov
force-pushed
the
traits-impl-methods-typecheck
branch
from
5f4539a to
40052a9
Compare
jfecher
reviewed
Sep 18, 2023
Contributor
jfecher
left a comment
jfecher
left a comment
There was a problem hiding this comment.
Looks mostly good. Can you move the type checking portion to the type checking pass rather than include it during name resolution?
tooling/nargo_cli/tests/compile_failure/dup_trait_implementation/src/main.nr
Show resolved
Hide resolved
Co-authored-by: jfecher <jfecher11@gmail.com>
jfecher
approved these changes
Sep 19, 2023
Contributor
jfecher
left a comment
jfecher
left a comment
There was a problem hiding this comment.
We can save moving the type checking to a later PR when it is easier to do so, as you mentioned. 👍
TomAFrench
added a commit
that referenced
this pull request
Sep 20, 2023
* master: feat(traits): Type checking for Trait impl method signatures (#2652) chore: split 9_conditional test case and remove 8_integration (#2751) chore(github): Add "Idea Action Plan" Issue template (#2736) feat(aztec-noir): abstract storage (#2750) feat: signed arithmetic (#2748) chore: encapsulate abstraction leaks from `bb` into new crate (#2747) feat: Variable liveness analysis for brillig (#2715) chore: noirjs integration testing (#2744) chore: Add rust-toolchain file & adapt nix for changes (#2686) chore: wrap backend info response in a struct instead of boxed closure (#2737) fix: check for literal overflows in expressions (#2742) fix: nightly js test (#2740) fix: keep the correct type for bitshift (#2739) chore: Make new daily nightly releases be pre-releases and non latest (#2735) chore: disabling display location section (#2118) chore: add a workflow that tracks acvm version for integration tests (#2700) feat: Save nightly build in github releases with date tags (#2416) chore: Add unified linting setup for JS code and enforce in CI (#2728)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary
This is further work on traits (#2568).
Self, a type variable is added in the Trait struct, which has to get bound to the concrete self type before we do the signature check mentioned aboveDocumentation
This PR requires documentation updates when merged.
Additional Context
PR Checklist*
cargo fmton default settings.