chore: Perform Circuit optimization in nargo#1394
Merged
kevaundray merged 16 commits intomasterfrom Jul 11, 2023
Merged
Conversation
8c4d8bb to
29e8b9e
Compare
29e8b9e to
e1debf7
Compare
TomAFrench
commented
May 24, 2023
5 tasks
guipublic
previously requested changes
May 25, 2023
5 tasks
Member
Author
|
@phated Relevant to LSP conversation. |
5 tasks
5 tasks
Member
Author
|
Merged something to fix all of the merge conflicts. I'm getting test failures which correspond to unoptimized ACIR trying to be passed to bberg somewhere which we need to address. |
Circuit optimization in nargo
Member
Author
|
This PR pulls the ACIR optimization up from This is desirable for a number of reasons, including:
|
kevaundray
reviewed
Jul 11, 2023
kevaundray
reviewed
Jul 11, 2023
moving towards compilation then optimization being separate so we can eventually compile without a backend
kevaundray
approved these changes
Jul 11, 2023
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem*
This PR removes all knowledge of which backend is being used from the driver + evaluator. Generic ACIR is then returned and is optimized in
nargo.The changes to the backend interface have thrown up an annoyance in that we need to optimize the circuit before we preprocess the circuit rather than allowing the backend to handle this itself. The current situation downloads a CRS based on the size of the unoptimized circuit rather than the one the backend will actually be using.Related to #1102
Summary*
This PR sets out to
Example
Before:
After:
Documentation
This PR requires documentation updates when merged.
Additional Context
PR Checklist*
cargo fmton default settings.