This repository was archived by the owner on Apr 9, 2024. It is now read-only.
chore(acvm)!: Remove CircuitSimplifer#421
Merged
kevaundray merged 1 commit intomasterfrom Jul 11, 2023
Merged
Conversation
kevaundray
approved these changes
Jul 11, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Addresses comment noir-lang/noir#1394 (comment)
Closes #307
Summary*
This PR removes the
CircuitSimplifierfrom the ACVM interface as it's unused and needs to be reworked in order to support separated ACIR generation and optimisation.Additional Context
PR Checklist*
cargo fmton default settings.