feat(lsp): Publish diagnostics on file save#1676
Merged
Conversation
phated
commented
Jun 13, 2023
phated
commented
Jun 13, 2023
phated
commented
Jun 13, 2023
phated
commented
Jun 13, 2023
phated
commented
Jun 13, 2023
phated
commented
Jun 13, 2023
phated
requested review from
TomAFrench,
jfecher,
jonybur,
kevaundray and
kobyhallx
kevaundray
reviewed
Jun 13, 2023
kevaundray
reviewed
Jun 13, 2023
phated
force-pushed
the
phated/lsp-diagnostics
branch
from
c212ac0 to
f659f33
Compare
jfecher
previously approved these changes
Jun 16, 2023
Contributor
jfecher
left a comment
jfecher
left a comment
There was a problem hiding this comment.
LGTM. I have one minor, non-blocking suggestion.
phated
force-pushed
the
phated/lsp-diagnostics
branch
from
f659f33 to
4861d18
Compare
kevaundray
approved these changes
Jun 16, 2023
Contributor
kevaundray
left a comment
kevaundray
left a comment
There was a problem hiding this comment.
I'm okay with merging this and creating issues for TODOs
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves #1584
Summary*
This adds diagnostic publishing to the LSP. We decided to only run the diagnostic check on file save and then we perform the "push" diagnostic pattern. This is due to the compiler not being built to operate in "pull" diagnostic mode since the client can request them at any time with source code provided; however, the compiler expects a filesystem graph and builds it from scratch. We also decided to only run this on save because "file change" notifications can come in quicker than we can compile them.
Documentation
This PR requires documentation updates when merged.
Additional Context
I need to create some follow up issues related to TODOs before I move this out of draft.
PR Checklist*
cargo fmton default settings.