chore(driver): Remove backend dependence from driver construction#1846
Merged
chore(driver): Remove backend dependence from driver construction#1846
Conversation
Contributor
|
How does this block dependency resolution? |
Contributor
Author
We want to store a Context and use references to it, which is leading me to pretty much remove Driver completely. Moving these values to function arguments makes this possible. |
TomAFrench
previously approved these changes
Jul 3, 2023
Member
TomAFrench
left a comment
TomAFrench
left a comment
There was a problem hiding this comment.
Looks good to me. I've added some notes in a couple of places.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves #1680
Summary*
This removes
languageandis_opcode_supportedarguments from the construction of theDriver. This is a half-measure while #1394 is outstanding. I tried to update that PR with upstream changes and all the tests were failing, so we should merge this intermediate step so I can continue moving forwards on fixing dependency resolution inside the LSP.Documentation
This PR requires documentation updates when merged.
Additional Context
While working on this, I noticed that we should be implementing Copy on the Language enum. See noir-lang/acvm#406
PR Checklist*
cargo fmton default settings.