chore: update noir for acir simplify feature#1333
Closed
Conversation
Contributor
|
I think these changes might need to be integrated into the PR for ACVM 0.12 #1339 |
Member
|
Heads up that this clashes with #1394 as we're not going to be calling |
5 tasks
5 tasks
Member
|
We can probably close this as we're not adding new features to the old SSA. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary of changes
This PR updates noir with the simplify PR in ACVM.
It provides an empty simplifier, which does nothing, to ACVM for compiling the circuit
The simplification is not activated because I want to be able to properly test it once noir is updated with the corresponding ACVM. However, because the compile function now takes the simplifier, noir needs to be updated, which is what this PR is for.
Error handling as been added to acir_gen because the simplification can find out that some arithmetic gates are not satisfied.
Dependency additions / changes
The PR does not update noir ACVM version, but it does require a new version. Until then, the PR will fail.
Test additions / changes
The feature is not enabled.
Checklist
cargo fmtwith default settings.Documentation needs