fix(frontend): No negative overflow when quoting signed integer#10331
fix(frontend): No negative overflow when quoting signed integer#10331
Conversation
…igned-int-quote-2
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Execution Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 35c246e | Previous: 1b1985e | Ratio |
|---|---|---|---|
rollup-checkpoint-merge |
0.004 s |
0.003 s |
1.33 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
…igned-int-quote-2
…te-2' into mv/no-neg-overflow-signed-int-quote-2
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Compilation Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 47164a5 | Previous: 975ef74 | Ratio |
|---|---|---|---|
sha512-100-bytes |
1.88 s |
1.533 s |
1.23 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
…igned-int-quote-2
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'ACVM Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 47164a5 | Previous: 975ef74 | Ratio |
|---|---|---|---|
perfectly_parallel_batch_inversion_opcodes |
2780428 ns/iter (± 918) |
2259283 ns/iter (± 826) |
1.23 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 47164a5 | Previous: 975ef74 | Ratio |
|---|---|---|---|
test_report_noir-lang_sha512_ |
16 s |
13 s |
1.23 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
|
Resolved merge conflicts and all looks good. Going to set for merge. |
Pull Request is not mergeable
Automated pull of nightly from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE chore: remove `local_annotations` from flattening (noir-lang/noir#10483) chore: better error recovery for multiple mut in pattern (noir-lang/noir#10490) chore(frontend): Tuple pattern tests and remove confusing arity error (noir-lang/noir#10480) chore: monomorphizer public fields (noir-lang/noir#9979) chore: remove a bunch of dummy definitions (noir-lang/noir#10482) feat(ssa): Limit the number of steps executed by the SSA interpreter during constant folding (noir-lang/noir#10481) fix: remove saturation from loop bound increments (noir-lang/noir#10479) fix(print): Print enums (noir-lang/noir#10472) fix(frontend): No negative overflow when quoting signed integer (noir-lang/noir#10331) chore: green light Brillig for audit (noir-lang/noir#10376) END_COMMIT_OVERRIDE
2 participants
Description
Problem*
Resolves #10328
Builds off of #10330
Summary*
We shouldn't use
-when getting the absolute value of an integer. We can use the Rustunsigned_absutility.Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.